Mk/bsd.port.mk: Added chemistry and physics virtual categories (for search purposes) {waiting for Jan 14}
Needs ReviewPublic

Authored by yuri on Dec 13 2017, 6:07 PM.

Details

Reviewers
tcberner
adamw
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

Added chemistry and physics virtual categories

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 13554
Build 13778: arc lint + arc unit
yuri created this revision.Dec 13 2017, 6:07 PM
tcberner accepted this revision.Dec 14 2017, 5:46 AM

Looks sensible to me. But you need the approval of portmgr for this.

adamw added a comment.Dec 14 2017, 5:59 AM

I think it's pretty fair to identify chemistry and physics stuff, given that we already do so for biology. However, empty categories are not useful----new categories must arrive fully-populated. What is the comprehensive list of ports you would assign to these categories?

yuri added a comment.EditedDec 14 2017, 6:31 AM

The partial list of ports for these categories:

Physics:
science/ALPSCore
science/p5-Physics-*
science/fisicalab
science/step
science/psychopy
science/clhep

Chemistry:
science/CheMPS2
science/libefp
science/p5-Chemistry-*
science/gchemutils
science/ghemical
science/bodr
science/mol2ps
science/openbabel
science/py-pyscf

Should I just add the category to those ports too in the same commit?

In D13481#281839, @yuri wrote:

The partial list of ports for these categories:

Physics:
science/ALPSCore
science/p5-Physics-*
science/fisicalab
science/step
science/psychopy
science/clhep

Chemistry:
science/CheMPS2
science/libefp
science/p5-Chemistry-*
science/gchemutils
science/ghemical
science/bodr
science/mol2ps
science/openbabel
science/py-pyscf

Should I just add the category to those ports too in the same commit?

There is also science/kalzium for chemistry. Yes please update the review with said ports included.

yuri updated this revision to Diff 36580.Dec 14 2017, 7:33 AM

Added categories to relevant ports.

mat added a comment.Dec 14 2017, 2:03 PM

I don't recall seeing a discussion about this on ports@.

yuri added a comment.Dec 15 2017, 5:02 PM
In D13481#281919, @mat wrote:

I don't recall seeing a discussion about this on ports@.

@mat So, it has been a discussion on ports@.
Can I commit it now?

mat added a comment.Dec 15 2017, 8:35 PM
In D13481#282268, @yuri wrote:
In D13481#281919, @mat wrote:

I don't recall seeing a discussion about this on ports@.

@mat So, it has been a discussion on ports@.
Can I commit it now?

Absolutely not. There has not been a discussion. You sent one email, there was one answer saying "nope", and one saying "meh". That is not a discussion.

See 5.3.4. Proposing a New Category.

So, what is going to happen is we wait at least, say, 30 days, see what comes of it, and if many other people like the idea, we'll look into this a bit more.

yuri retitled this revision from Mk/bsd.port.mk: Added chemistry and physics virtual categories (for search purposes). to Mk/bsd.port.mk: Added chemistry and physics virtual categories (for search purposes) {waiting for Jan 14}.Dec 20 2017, 2:34 AM