Page MenuHomeFreeBSD

New port: misc/libpostal: Library for parsing/normalizing street addresses around the world
ClosedPublic

Authored by yuri on Dec 12 2017, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 15, 1:59 AM
Unknown Object (File)
Fri, Oct 10, 6:59 AM
Unknown Object (File)
Tue, Oct 7, 4:46 PM
Unknown Object (File)
Mon, Oct 6, 2:14 AM
Unknown Object (File)
Fri, Oct 3, 8:40 AM
Unknown Object (File)
Tue, Sep 30, 2:05 AM
Unknown Object (File)
Mon, Sep 29, 11:21 PM
Unknown Object (File)
Mon, Sep 29, 1:04 AM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dmgk added inline comments.
misc/libpostal/files/patch-src_Makefile.am
7 ↗(On Diff #36524)

$(datadir) should be without libpostal suffix.

misc/libpostal/files/patch-test_Makefile.am
4 ↗(On Diff #36524)

Same as above, should be just $(datadir) w/o suffix.

misc/libpostal/pkg-plist
10 ↗(On Diff #36524)

This is not needed, LIBPOSTAL_DATADIR will be created by libpostal_data script on first data download.

misc/libpostal/Makefile
20 ↗(On Diff #36524)

If we're not patching configure.ac, then configure needs CFLAGS and CPPFLAGS with -I${LOCALBASE}/include, otherwise CBLAS options is noop (configure doesn't find cblas.h)

misc/libpostal/files/patch-test_Makefile.am
4 ↗(On Diff #36524)

This one is OK actually, please disregard.

misc/libpostal/pkg-plist
5 ↗(On Diff #36528)

^ can you get rid of this, like in the other ports?

yuri marked an inline comment as done.Dec 13 2017, 6:12 AM
yuri added inline comments.
misc/libpostal/pkg-plist
5 ↗(On Diff #36528)

Sorry, I forgot to mention. This port is going to be used in one go-package, and it appears that go needs static libraries. Submitter asked to leave it.

yuri marked 2 inline comments as done.Dec 13 2017, 6:12 AM
misc/libpostal/Makefile
39 ↗(On Diff #36528)

Ports should not use static libraries. Doesn't math/openblas provide a shared library that this can use ?

50–51 ↗(On Diff #36528)
post-install-DOCS-on:
misc/libpostal/pkg-plist
5 ↗(On Diff #36528)

Go ports must not depend on static libraries, they must build everything they need themselves.

misc/libpostal/pkg-plist
5 ↗(On Diff #36528)

Hi Tobias,

I'm ok with removing static libs, just wondering - is it a general policy in ports not to install static libs?

yuri marked 4 inline comments as done.Dec 13 2017, 5:24 PM

STATIC option has been added. STATIC=off by default.

misc/libpostal/Makefile
14 ↗(On Diff #36558)

This should be just curl:ftp/curl.

50–51 ↗(On Diff #36528)

You marked this as done, but it hasn't been done.

yuri added inline comments.
misc/libpostal/Makefile
50–51 ↗(On Diff #36528)

Sorry, I missed this one. Now it's done.

yuri marked an inline comment as done.

.

This revision is now accepted and ready to land.Dec 18 2017, 10:38 PM
This revision was automatically updated to reflect the committed changes.