Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| misc/libpostal/files/patch-src_Makefile.am | ||
|---|---|---|
| 7 ↗ | (On Diff #36524) | $(datadir) should be without libpostal suffix. |
| misc/libpostal/files/patch-test_Makefile.am | ||
| 4 ↗ | (On Diff #36524) | Same as above, should be just $(datadir) w/o suffix. |
| misc/libpostal/pkg-plist | ||
| 10 ↗ | (On Diff #36524) | This is not needed, LIBPOSTAL_DATADIR will be created by libpostal_data script on first data download. |
| misc/libpostal/Makefile | ||
|---|---|---|
| 20 ↗ | (On Diff #36524) | If we're not patching configure.ac, then configure needs CFLAGS and CPPFLAGS with -I${LOCALBASE}/include, otherwise CBLAS options is noop (configure doesn't find cblas.h) |
| misc/libpostal/files/patch-test_Makefile.am | ||
|---|---|---|
| 4 ↗ | (On Diff #36524) | This one is OK actually, please disregard. |
| misc/libpostal/pkg-plist | ||
|---|---|---|
| 5 ↗ | (On Diff #36528) | ^ can you get rid of this, like in the other ports? |
| misc/libpostal/pkg-plist | ||
|---|---|---|
| 5 ↗ | (On Diff #36528) | Sorry, I forgot to mention. This port is going to be used in one go-package, and it appears that go needs static libraries. Submitter asked to leave it. |
| misc/libpostal/Makefile | ||
|---|---|---|
| 39 ↗ | (On Diff #36528) | Ports should not use static libraries. Doesn't math/openblas provide a shared library that this can use ? |
| 50–51 ↗ | (On Diff #36528) | post-install-DOCS-on: |
| misc/libpostal/pkg-plist | ||
| 5 ↗ | (On Diff #36528) | Go ports must not depend on static libraries, they must build everything they need themselves. |
| misc/libpostal/pkg-plist | ||
|---|---|---|
| 5 ↗ | (On Diff #36528) | Hi Tobias, I'm ok with removing static libs, just wondering - is it a general policy in ports not to install static libs? |
| misc/libpostal/Makefile | ||
|---|---|---|
| 50–51 ↗ | (On Diff #36528) | Sorry, I missed this one. Now it's done. |