Page MenuHomeFreeBSD
Differential D13455

u-boot-tools: Add new ports u-boot-tools
ClosedPublic
Actions

Authored by manu on Dec 11 2017, 9:27 PM.
Tags
None
Referenced Files
F132256932: D13455.id36502.diff
Wed, Oct 15, 6:15 AM
Unknown Object (File)
Mon, Oct 13, 1:57 PM
Unknown Object (File)
Tue, Oct 7, 10:46 PM
Unknown Object (File)
Fri, Sep 26, 1:39 PM
Unknown Object (File)
Wed, Sep 24, 9:05 AM
Unknown Object (File)
Sun, Sep 21, 8:18 PM
Unknown Object (File)
Sat, Sep 20, 11:26 PM
Unknown Object (File)
Sat, Sep 20, 8:49 PM
View All Files
Subscribers
mat
mmel

Details

Reviewers
imp
linimon
mmel
mat
Commits
rP456671: Add new port sysutils/u-boot-tools
Summary

u-boot-tools contain tools for creating and analyzing u-boot images.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Dec 11 2017, 9:27 PM
Herald added a subscriber: mat. · View Herald TranscriptDec 11 2017, 9:27 PM
imp accepted this revision.Dec 11 2017, 9:37 PM
This revision is now accepted and ready to land.Dec 11 2017, 9:37 PM
mmel accepted this revision.Dec 12 2017, 4:51 AM

Thanks !!!

sysutils/u-boot-tools/files/patch-Makefile
8 ↗(On Diff #36481)

This looks like mistake / bad diff

mmel added inline comments.Dec 12 2017, 4:54 AM
sysutils/u-boot-tools/files/patch-Makefile
8 ↗(On Diff #36481)

Oups, taking back, sorry for noise.

mat requested changes to this revision.Dec 12 2017, 11:53 AM
mat added inline comments.
sysutils/u-boot-tools/pkg-descr
1 ↗(On Diff #36481)

Please make this longer than the COMMENT line, a paragraph, at least a couple of lines long.

3 ↗(On Diff #36481)

This is wrong.

WWW: http://www.denx.de/wiki/U-Boot
This revision now requires changes to proceed.Dec 12 2017, 11:53 AM
manu updated this revision to Diff 36500.Dec 12 2017, 12:16 PM

Expand pkg-descr.

manu marked 4 inline comments as done.Dec 12 2017, 12:17 PM
mat added inline comments.Dec 12 2017, 12:27 PM
sysutils/u-boot-tools/pkg-descr
7 ↗(On Diff #36500)

This can be removed, I doubt anyone will believe you put a link to some oriental soup recipe.

manu updated this revision to Diff 36502.Dec 12 2017, 12:41 PM

Remove useless sentence

manu marked an inline comment as done.Dec 12 2017, 12:42 PM
manu added a comment.Dec 18 2017, 2:16 PM

Ping

imp accepted this revision.Dec 18 2017, 2:57 PM

I see nothing wrong with this port. It can be committed now that the useless nitpicking over the pkg-descr has timed out.

This revision was not accepted when it landed; it landed in state Needs Review.Dec 18 2017, 7:20 PM
Closed by commit rP456671: Add new port sysutils/u-boot-tools (authored by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sysutils/
1 line
u-boot-tools/
33 lines
3 lines
files/
20 lines
7 lines

Diff 36721

View Options

head/sysutils/Makefile

Loading...
View Options

head/sysutils/u-boot-tools/Makefile

Loading...
View Options

head/sysutils/u-boot-tools/distinfo

Loading...
View Options

head/sysutils/u-boot-tools/files/patch-Makefile

Loading...
View Options

head/sysutils/u-boot-tools/pkg-descr

Loading...