Prepare openvsp for CMake 3.10
AbandonedPublic
Actions

Authored by adridg on Dec 11 2017, 12:17 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 8, 4:39 AM

	Unknown Object (File)
	Thu, Apr 2, 2:00 AM

	Unknown Object (File)
	Thu, Mar 26, 4:31 AM

	Unknown Object (File)
	Wed, Mar 25, 9:12 PM

	Unknown Object (File)
	Fri, Mar 20, 12:03 PM

	Unknown Object (File)
	Fri, Mar 20, 7:06 AM

	Unknown Object (File)
	Tue, Mar 17, 3:55 PM

	Unknown Object (File)
	Mon, Mar 16, 1:07 PM

View All 73 Files

Subscribers

mat

Details

Reviewers

swills
tcberner

Summary

Uses libxml, without looking for it; currently this builds,
but newer cmake doesn't set up the variables the same way
(I guess some accidental import is happening in cmake 3.9),
so link fails with libxml-not-found. To fix, just look for
libxml.

Test Plan

See http://package23.nyi.freebsd.org/data/103i386-default-PR223872/2017-11-27_14h43m28s/logs/errors/openvsp-3.13.3_1.log for error log; with this patch the same failure no longer happens; harmless in CMake 3.9.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 13472
Build 13698: arc lint + arc unit

Event Timeline

adridg created this revision.Dec 11 2017, 12:17 PM

Harbormaster completed remote builds in B13472: Diff 36447.Dec 11 2017, 12:17 PM

Herald added a subscriber: mat. · View Herald TranscriptDec 11 2017, 12:17 PM

tcberner accepted this revision.Dec 12 2017, 6:25 AM

This revision is now accepted and ready to land.Dec 12 2017, 6:25 AM

Will do cmake update plus all these related fixes in one go in PR 223872

Revision Contents
Changeset List

Path

Size

cad/

openvsp/

Makefile

1 line

files/

patch-src_vsp_CMakeLists.txt

11 lines

Diff 36447

View Options

cad/openvsp/Makefile