Page MenuHomeFreeBSD

Make using github releases easier
ClosedPublic

Authored by swills on Dec 19 2014, 5:17 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 31 2022, 5:37 PM
Unknown Object (File)
Dec 28 2022, 12:45 AM
Unknown Object (File)
Dec 24 2022, 9:19 AM
Unknown Object (File)
Dec 23 2022, 10:11 AM
Unknown Object (File)
Dec 15 2022, 11:30 AM
Unknown Object (File)
Nov 29 2022, 5:52 AM
Unknown Object (File)
Apr 4 2017, 1:37 PM
Unknown Object (File)
Dec 9 2016, 11:52 AM

Details

Reviewers
bapt
Group Reviewers
portmgr

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

swills retitled this revision from to Make using github releases easier.
swills updated this object.
swills edited the test plan for this revision. (Show Details)
glebius added inline comments.
Mk/bsd.sites.mk
1525

The "v" here isn't a common place. The "dummy" stuff isn't needed.

IMHO, this should be:

${GH_ACCOUNT}/${GH_PROJECT}/archive/${DISTNAME}

Or may be:

${GH_ACCOUNT}/${GH_PROJECT}/archive/${GH_TAG}

not sure

bapt requested changes to this revision.Dec 19 2014, 10:27 AM
bapt added a reviewer: bapt.
bapt added a subscriber: bapt.
bapt added inline comments.
Mk/bsd.sites.mk
1525

I would rather use

${DISTVERSIONPREFIX}${DISTVERSION:C/:(.)/\1/g}${DISTVERSIONSUFFIX}${EXTRACT_SUFX}

like how it is defined in DISTNAME
So that for the v is becomes a simple DISTVERSIONPREFIX=v like it should be

This revision now requires changes to proceed.Dec 19 2014, 10:27 AM
swills edited edge metadata.

Copy bits from DISTNAME

bapt edited edge metadata.
This revision is now accepted and ready to land.Dec 20 2014, 12:31 PM

Committed in rP375010 but not noted here for some reason.

Mk/bsd.sites.mk
1525

In my experience, the dummy stuff is needed. Can you explain more why you think it isn't?

1525

I like copying the DISTNAME bit, but had to make some further changes to get it working. Will post updated diff.

bdrewery added inline comments.
Mk/bsd.sites.mk
1525

I removed this in r381648. I wanted to mention though that all of the DIST stuff here is not needed. Everything before ?dummy is what we're telling github is the tag we want to fetch. The fetching automatically adds DISTNAME after the MASTER_SITE URL, hence the ?dummy=/. This will fetch the file as DISTNAME. You can see this here:

~/svn/ports.commit/ports-mgmt/poudriere-devel # make fetch-urlall-list|grep github
https://codeload.github.com/freebsd/poudriere/tar.gz/80b7167?dummy=/freebsd-poudriere-3.1.99.20150319-80b7167.tar.gz

So DISTNAME is already used.

Mk/bsd.sites.mk
1525

I do see the benefit in this now. I am moving it to GH_TAGNAME?= ${DISTVERSION} instead though.

Mk/bsd.sites.mk
1525

Done in r381689