Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Mk/bsd.sites.mk | ||
---|---|---|
1525 | The "v" here isn't a common place. The "dummy" stuff isn't needed. IMHO, this should be: ${GH_ACCOUNT}/${GH_PROJECT}/archive/${DISTNAME} Or may be: ${GH_ACCOUNT}/${GH_PROJECT}/archive/${GH_TAG} not sure |
Mk/bsd.sites.mk | ||
---|---|---|
1525 | I would rather use ${DISTVERSIONPREFIX}${DISTVERSION:C/:(.)/\1/g}${DISTVERSIONSUFFIX}${EXTRACT_SUFX} like how it is defined in DISTNAME |
Mk/bsd.sites.mk | ||
---|---|---|
1525 | I removed this in r381648. I wanted to mention though that all of the DIST stuff here is not needed. Everything before ?dummy is what we're telling github is the tag we want to fetch. The fetching automatically adds DISTNAME after the MASTER_SITE URL, hence the ?dummy=/. This will fetch the file as DISTNAME. You can see this here: ~/svn/ports.commit/ports-mgmt/poudriere-devel # make fetch-urlall-list|grep github So DISTNAME is already used. |
Mk/bsd.sites.mk | ||
---|---|---|
1525 | I do see the benefit in this now. I am moving it to GH_TAGNAME?= ${DISTVERSION} instead though. |
Mk/bsd.sites.mk | ||
---|---|---|
1525 | Done in r381689 |