Page MenuHomeFreeBSD

[new port] archivers/py-xopen: Open compressed files transparently
ClosedPublic

Authored by jwb on Nov 29 2017, 1:55 PM.

Details

Summary

[new port] archivers/py-xopen: Open compressed files transparently
Approved by jrm (mentor) or wen (mentor)
Differential to be added to commit message

Test Plan

portlint -A: looks fine
Passed poudriere on {10.4,11.1}-{amd64,i386}
Tested in production as dependency of cutadapt bioinformatics software

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jwb created this revision.Nov 29 2017, 1:55 PM
jrm added a comment.Nov 29 2017, 2:32 PM
  • If @mat were here, he would ask you to remove the # Created by: since it repeats information in repo history.
  • If you want to reduce the chances of broken package builds, you could use the same OS versions for you poudriere jails that cluster uses (lowest supported major OS version). See https://pkg-status.freebsd.org/.
  • Don't forget to add an entry in archivers/Makefile. Without this, INDEX builds will break.
archivers/py-xopen/Makefile
17 ↗(On Diff #35953)

NO_ARCH=yes

mat added a comment.Nov 29 2017, 2:36 PM
In D13292#277318, @jrm wrote:
  • If @mat were here, he would ask you to remove the # Created by: since it repeats information in repo history.

I stopped doing that, some people like the ego boost it gives.

  • Don't forget to add an entry in archivers/Makefile. Without this, INDEX builds will break.

Or use Tools/script/addport to add the port, like you should, it will also make sure you resurrect the port if it needs to be resurrected.

jwb marked an inline comment as done.Nov 29 2017, 3:48 PM

Thanks for the tip on addport.

I have no need for ego fodder, so I'll remove the "Created by" header. It was inserted by "port create".

archivers/py-xopen/Makefile
17 ↗(On Diff #35953)

Thanks, NO_ARCH is in my checklist already, but I slipped on this one.

jwb marked an inline comment as done.Nov 29 2017, 3:50 PM
jwb updated this revision to Diff 35958.

Add NO_ARCH=yes and remove "Created by" per mentor suggestions.

jrm accepted this revision.Nov 29 2017, 3:54 PM
This revision is now accepted and ready to land.Nov 29 2017, 3:54 PM
This revision was automatically updated to reflect the committed changes.