Fix assertion when ZFS fails to open certain devices
ClosedPublic
Actions

Authored by asomers on Nov 27 2017, 10:03 PM.

Details

Reviewers

Commits

rS330522: MFC r326401:
rS329780: MFC r326399:
rS327188: MFC r326401:
rS326401: Fix assertion when ZFS fails to open certain devices
rS326399: Fix assertion when ZFS fails to open certain devices

Summary

Fix assertion when ZFS fails to open certain devices

"panic: vdev_geom_close_locked: cp->private is NULL"
This panic will result if ZFS fails to open a device due to either of the
following reasons:

The device's sector size is greater than 8KB.
ZFS wants to open the device RW, but it can't be opened for writing.

The solution is to change the initialization order to ensure that the
assertion will be satisfied.

PR: 221066

Test Plan

The minimal test case as described by the PR, and the ZFS test
suite.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Nov 27 2017, 10:03 PM

Herald added subscribers: delphij, imp. · View Herald TranscriptNov 27 2017, 10:03 PM

LGTM. Thank you!

This revision is now accepted and ready to land.Nov 30 2017, 9:51 AM

Closed by commit rS326399: Fix assertion when ZFS fails to open certain devices (authored by asomers). · Explain WhyNov 30 2017, 3:28 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

cddl/

contrib/

opensolaris/

uts/

common/

fs/

zfs/

vdev_raidz.c

7 lines

Diff 36004

View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/vdev_raidz.c

Fix assertion when ZFS fails to open certain devicesClosedPublicActions