Avoid unneeded initializations in vm_phys_init_page().
ClosedPublic
Actions

Authored by markj on Nov 25 2017, 10:37 PM.

Details

Reviewers

alc
kib

Commits

rS326234: Remove unneeded initializations from vm_phys_init_page().

Summary

The aflags and oflags fields are always initialized by the vm_page.c
allocators.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Nov 25 2017, 10:37 PM

Harbormaster completed remote builds in B13065: Diff 35788.Nov 25 2017, 10:37 PM

markj added reviewers: alc, kib.Nov 25 2017, 10:37 PM

alc accepted this revision.Nov 26 2017, 5:03 AM

This revision is now accepted and ready to land.Nov 26 2017, 5:03 AM

You mean that the allocators vm_page_alloc(), vm_page_alloc_contig(), and vm_page_alloc_freelist() overwrite the fields anyway.

What is the point of keeping the function in vm_phys.c ? If moved to vm_page.c, compiler most likely inlines its only use.

In D13242#276188, @kib wrote:

You mean that the allocators vm_page_alloc(), vm_page_alloc_contig(), and vm_page_alloc_freelist() overwrite the fields anyway.

What is the point of keeping the function in vm_phys.c ? If moved to vm_page.c, compiler most likely inlines its only use.

For that, vm_phys_paddr_to_segind() needs to be changed from static to extern. I would be fine with that too.

Closed by commit rS326234: Remove unneeded initializations from vm_phys_init_page(). (authored by markj). · Explain WhyNov 26 2017, 7:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_phys.c

2 lines

Diff 35818

View Options

Avoid unneeded initializations in vm_phys_init_page().ClosedPublicActions