Paths

Table of Contentst

Differential D13189

audio/py-pyliblo: Update: Removed the unnecessary dependency on pyrex; Made it python3-compatible; Added USES=localbase:ldflags.
ClosedPublic
Actions

Authored by yuri on Nov 21 2017, 11:59 PM.

Tags

None

Referenced Files

	F139339642: D13189.diff
	Thu, Dec 11, 12:20 AM

	Unknown Object (File)
	Wed, Dec 10, 2:37 AM

	Unknown Object (File)
	Tue, Dec 9, 11:12 PM

	Unknown Object (File)
	Thu, Dec 4, 11:25 PM

	Unknown Object (File)
	Wed, Nov 26, 4:31 PM

	Unknown Object (File)
	Sun, Nov 23, 6:57 AM

	Unknown Object (File)
	Fri, Nov 21, 6:58 AM

	Unknown Object (File)
	Fri, Nov 21, 6:57 AM

Subscribers

Details

Reviewers

tcberner
adamw

Commits

rP454893: audio/py-pyliblo: Update: Removed the unnecessary dependency on pyrex; Made it…

Summary

Verified that it builds and works.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Nov 21 2017, 11:59 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 21 2017, 11:59 PM

Harbormaster completed remote builds in B12931: Diff 35572.Nov 21 2017, 11:59 PM

tcberner added inline comments.Nov 22 2017, 5:48 AM

audio/py-pyliblo/Makefile
17 ↗	(On Diff #35572)	^ Apart from looking a bit on the overdesigned side, also you should not need to add a path for BUILD/RUN_DEPENDS in $PATH.

.

yuri marked an inline comment as done.Nov 22 2017, 5:51 AM

yuri added inline comments.

audio/py-pyliblo/Makefile
17 ↗	(On Diff #35572)	This should be made into `USE_PYTHON=cython`. Maybe I will submit such patch later.

yuri marked 2 inline comments as done.Nov 22 2017, 5:51 AM

mat added inline comments.Nov 24 2017, 6:05 PM

audio/py-pyliblo/Makefile
17 ↗	(On Diff #35572)	There is one, it comes with the flavors patch.

So let's wait for that then? :D

In D13189#275515, @tcberner wrote:

So let's wait for that then? :D

Can we not wait, and instead add a note to update this when available?

yuri marked an inline comment as done.Nov 24 2017, 7:13 PM

we can :)

This revision is now accepted and ready to land.Nov 25 2017, 11:01 AM

Closed by commit rP454893: audio/py-pyliblo: Update: Removed the unnecessary dependency on pyrex; Made it… (authored by yuri). · Explain WhyNov 25 2017, 8:30 PM

This revision was automatically updated to reflect the committed changes.

mat added inline comments.Nov 27 2017, 12:09 PM

head/audio/py-pyliblo/Makefile
22	I don't understand the comment here. `USE_PYTHON=autoplist` looks at what files `distutils` has installed and uses that to generate the plist. In this port, the man pages are installed manually in post-install, so there is no way that distutils knows about them, so it seems normal that they are not present in the plist generated by autoplist.

Revision Contents
Changeset List

Path

Size

head/

audio/

py-pyliblo/

10 lines

Diff 35774

head/audio/py-pyliblo/Makefile

Loading...