New port: devel/gogs: Painless self-hosted Git service

[yuri]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=205283

[tcberner]

devel/gogs/Makefile

38

^ add GOGS_DBDIR and GOGS_LOGDIR, see comment in gogs-rm-data.in

devel/gogs/files/gogs-rm-data.in

21

%%GOGS_DBDIR%% and %%GOGS_LOGDIR%%

https://www.freebsd.org/doc/en/books/porters-handbook/using-sub-files.html

devel/gogs/pkg-plist

4

^ Section 7.6.13.1. -- you can combine this to
@(%%GOCS_USER%%, %%GOGS_GROUP%%, 640) libexec/gogs/custom/conf/app.ini
this is much easier to handle when the plist changes :)

1726

^ should not be necessary as it is non-empty and in prefix

[dmgk]

devel/gogs/pkg-plist

1726

It's needed because gogs user has to be able to create (temp) files in this dir when editing app settings from inside the app.

[tcberner]

devel/gogs/pkg-plist

1726

sorry, I overloked the mode change operations on the directory

[yuri]

Requested changes.

[yuri]

.

[dmgk]

devel/gogs/pkg-plist

4

A typo, should be GOGS_USER

[yuri]

devel/gogs/pkg-plist

4

Good catch! Thanks!

[yuri]

.

[adamw]

devel/gogs/Makefile

35

This isn't right. This port installs into PREFIX, not LOCALBASE. LOCALBASE is where the dependencies have been installed.

[yuri]

LOCALBASE -> PREFIX

[yuri]

This breaks in pkg install:

@(%%GOGS_USER%%, %%GOGS_GROUP%%, 640) libexec/gogs/custom/conf/app.ini

with this error:

pkg-static: Malformed keyword (gogs,, expecting @keyword or @keyword(owner,group,mode)

The file work/.PLIST.mktmp has this line: @(gogs, gogs, 640) libexec/gogs/custom/conf/app.ini - it looks to be correctly expanded.

There is some bug which I didn't figure out yet.

The port devel/flyspray does a similar thing in pkg-plist, but it doesn't break like this.

The difference with devel/flyspray is that gogs creates the user/group combination, and flyspray doesn't. This might be a bug in pkg.

I suggest to roll this change back until it is figured out, so that gogs can be committed.

Bug for pkg can be created with gogs as an example once it is committed.

[adamw]

The problem is the spaces.

[yuri]

In D13141#273722, @adamw wrote:

The problem is the spaces.

Thanks Adam!

https://github.com/freebsd/pkg/issues/1630

[yuri]

Removed spaces in macro in pkg-plist.

[tcberner]

devel/gogs/Makefile

23

^ I'm a bit confused. The user is already present in the UIDs/GIDs -- are you sure this port is not already present somehwere? :D

[tcberner]

r408986 | pi | 2016-02-16 12:04:10 +0100 (Di., 16 Feb. 2016) | 5 lines

devel/gogs (new port, not yet in the tree): reserve UIDs and GIDs

that clears that up nicely.

[yuri]

devel/gogs/Makefile

23

I originally submitted this port with the suggestion of UID/GID addition. UID/GID must have been added back then.

This port isn't yet present anywhere. -)

[tcberner]

I'm fine with this, as long as @adamw has nothing more to add.

[yuri]

In D13141#274076, @tcberner wrote:

I'm fine with this, as long as @adamw has nothing more to add.

I will wait for @adamw to confirm then.

[adamw]

I'm happy!

[yuri]

In D13141#274199, @adamw wrote:

I'm happy!

Thanks!

[mat]

head/devel/gogs/Makefile

69–71 ↗

(On Diff #35499)

Both LN should probably be using ${RLN} instead.

[dmgk]

head/devel/gogs/Makefile

69–71 ↗

(On Diff #35499)

GOGS_DBDIR and GOGS_LOGDIR are outside of PREFIX (by default).

[yuri]

head/devel/gogs/Makefile

69–71 ↗

(On Diff #35499)

@mat Do you still want to reopen this?

[tcberner]

https://www.freebsd.org/doc/en/books/porters-handbook/special.html#staging-symlink

You can double check the above document ^ . If there _is_ something to fix, fix it :)

[yuri]

In D13141#275858, @tcberner wrote:

https://www.freebsd.org/doc/en/books/porters-handbook/special.html#staging-symlink

You can double check the above document ^ . If there _is_ something to fix, fix it :)

The above link leads to the conclusion that there's nothing to fix. -)

[tcberner]

In D13141#275859, @yuri wrote:

In D13141#275858, @tcberner wrote:

https://www.freebsd.org/doc/en/books/porters-handbook/special.html#staging-symlink

You can double check the above document ^ . If there _is_ something to fix, fix it :)

The above link leads to the conclusion that there's nothing to fix. -)

You have your answer then :)

[mat]

head/devel/gogs/Makefile

69–71 ↗

(On Diff #35499)

No, I did not notice they were outside of PREFIX.