New port: misc/owrep: Weather reporting program based on openweathermap.org

[yuri]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223247

[yuri]

.

[tcberner]

misc/owrep/Makefile

5

^ use DISTVERSION for new ports

21

^ I think @adamw mentioned in the tio-commit, that you should put them into a plist if they contain substitutions.

[yuri]

.

[tcberner]

misc/owrep/pkg-plist

1

^ do as the nice line tells you :D

[yuri]

.

[adamw]

misc/owrep/Makefile

21

FWIW, the issue is that %% things are to pass variables into the plist. If the plist is in the Makefile, there's no need to expand variables.

PLIST_FILES=    %%ETCDIR%%.conf.sample

should just be:

PLIST_FILES=    ${ETCDIR_REL}.conf.sample

That said, %%ETCDIR%%.conf.sample is pretty gross. That really should be etc/%%PORTNAME%%.conf.sample.

What absolutely do require a separate plist are commands (like @sample, @dir, etc.).

[mat]

head/misc/owrep/pkg-plist

2 ↗

(On Diff #35334)

This is wrong.

%%ETCDIR%% should always be followed by a /, it is a directory name, not a "bit of a filename".

[tcberner]

@yuri can you prepare a fix for the mistake -- sorry my bad :/

[yuri]

Fixed the %%ETCDIR%% problem.

[yuri]

misc/owrep/Makefile

21

@adamw , sorry I missed your original comment!
Now this is fixed.

[yuri]

.

[yuri]

This wasn't closed somehow.