Page MenuHomeFreeBSD

New port: misc/owrep: Weather reporting program based on openweathermap.org
AbandonedPublic

Authored by yuri on Nov 16 2017, 9:04 AM.
Tags
None
Referenced Files
F167425626: D13118.id35314.diff
Fri, Aug 21, 4:09 PM
F167411688: D13118.id35732.diff
Fri, Aug 21, 2:58 PM
F167410785: D13118.id35736.diff
Fri, Aug 21, 2:53 PM
F167405248: D13118.id35329.diff
Fri, Aug 21, 2:19 PM
F167398091: D13118.id35327.diff
Fri, Aug 21, 1:21 PM
F167387390: D13118.id35334.diff
Fri, Aug 21, 12:13 PM
F167320102: D13118.id35313.diff
Thu, Aug 20, 9:15 PM
F167309307: D13118.id35329.diff
Thu, Aug 20, 8:11 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13029
Build 13283: arc lint + arc unit

Event Timeline

misc/owrep/Makefile
4

^ use DISTVERSION for new ports

20

^ I think @adamw mentioned in the tio-commit, that you should put them into a plist if they contain substitutions.

yuri marked 2 inline comments as done.Nov 16 2017, 6:26 PM
misc/owrep/pkg-plist
1

^ do as the nice line tells you :D

yuri marked an inline comment as done.Nov 16 2017, 6:32 PM
This revision is now accepted and ready to land.Nov 16 2017, 6:35 PM
This revision was automatically updated to reflect the committed changes.
misc/owrep/Makefile
20

FWIW, the issue is that %% things are to pass variables into the plist. If the plist is in the Makefile, there's no need to expand variables.

PLIST_FILES=    %%ETCDIR%%.conf.sample

should just be:

PLIST_FILES=    ${ETCDIR_REL}.conf.sample

That said, %%ETCDIR%%.conf.sample is pretty gross. That really should be etc/%%PORTNAME%%.conf.sample.

What absolutely do require a separate plist are commands (like @sample, @dir, etc.).

head/misc/owrep/pkg-plist
2 ↗(On Diff #35334)

This is wrong.

%%ETCDIR%% should always be followed by a /, it is a directory name, not a "bit of a filename".

@yuri can you prepare a fix for the mistake -- sorry my bad :/

Fixed the %%ETCDIR%% problem.

yuri marked an inline comment as done.Nov 24 2017, 8:30 PM
yuri added inline comments.
misc/owrep/Makefile
20

@adamw , sorry I missed your original comment!
Now this is fixed.

yuri marked 2 inline comments as done.Nov 24 2017, 8:30 PM

This wasn't closed somehow.