Page MenuHomeFreeBSD
Differential D13091

New port: x11-fonts/google-fonts: Collection of freely redistributable TrueType fonts from Google
ClosedPublic
Actions

Authored by yuri on Nov 14 2017, 5:58 PM.
Tags
None
Referenced Files
F165672878: D13091.id35414.diff
Sun, Aug 9, 3:51 AM
Unknown Object (File)
Sat, Aug 8, 1:15 PM
Unknown Object (File)
Fri, Aug 7, 6:23 PM
Unknown Object (File)
Thu, Aug 6, 7:44 PM
Unknown Object (File)
Mon, Aug 3, 11:38 PM
Unknown Object (File)
Mon, Aug 3, 6:47 PM
Unknown Object (File)
Mon, Aug 3, 6:47 PM
Unknown Object (File)
Mon, Aug 3, 2:05 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP454448: New port: x11-fonts/google-fonts: Collection of freely redistributable TrueType…
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223652

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuri created this revision.Nov 14 2017, 5:58 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 14 2017, 5:58 PM
Harbormaster completed remote builds in B12744: Diff 35242.Nov 14 2017, 5:58 PM
tcberner added inline comments.Nov 14 2017, 6:12 PM
x11-fonts/google-fonts/Makefile
13 ↗(On Diff #35242)

wouldn't it make more sense to add the rest of them also separately, and have this one as a metaport?

yuri marked an inline comment as done.Nov 14 2017, 6:15 PM
yuri added inline comments.
x11-fonts/google-fonts/Makefile
13 ↗(On Diff #35242)

Ok, I will ask the original submitter.

yuri marked 2 inline comments as done.Nov 14 2017, 6:16 PM
yuri added inline comments.Nov 14 2017, 6:23 PM
x11-fonts/google-fonts/Makefile
13 ↗(On Diff #35242)

He says that there are over 800 font families. He created these RUN_DEPENDS to avoid duplication with preexisting ports that happened to exist for some individual ones.

tcberner added inline comments.Nov 14 2017, 6:31 PM
x11-fonts/google-fonts/Makefile
60 ↗(On Diff #35242)

This should go simpler [tm]

yuri marked an inline comment as done.Nov 14 2017, 6:48 PM
yuri marked an inline comment as done.
yuri added inline comments.
x11-fonts/google-fonts/Makefile
60 ↗(On Diff #35242)

What do you mean by simpler? -)

tcberner added a comment.Nov 14 2017, 6:50 PM

wihtout nested for-loops :) ... I may b wrong, but it looks a bit overdesigned ^^

yuri marked an inline comment as done.Nov 14 2017, 6:52 PM
In D13091#272201, @tcberner wrote:

wihtout nested for-loops :) ... I may b wrong, but it looks a bit overdesigned ^^

Ok, I passed your suggestion to the OP.

I will be off for a few hours.

Thank you for reviewing! :-)

yuri updated this revision to Diff 35265.Nov 15 2017, 4:05 AM

Simplified the install target.

Harbormaster completed remote builds in B12755: Diff 35265.Nov 15 2017, 4:05 AM
yuri marked an inline comment as done.Nov 16 2017, 7:19 AM
tcberner accepted this revision.Nov 18 2017, 10:29 AM
This revision is now accepted and ready to land.Nov 18 2017, 10:29 AM
Closed by commit rP454448: New port: x11-fonts/google-fonts: Collection of freely redistributable TrueType… (authored by yuri). · Explain WhyNov 18 2017, 4:46 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
x11-fonts/
1 line
google-fonts/
66 lines
3 lines
files/
8 lines
5 lines
4640 lines

Diff 35414

View Options

head/x11-fonts/Makefile

Loading...
View Options

head/x11-fonts/google-fonts/Makefile

Loading...
View Options

head/x11-fonts/google-fonts/distinfo

Loading...
View Options

head/x11-fonts/google-fonts/files/pkg-message.in

Loading...
View Options

head/x11-fonts/google-fonts/pkg-descr

Loading...
View Options

head/x11-fonts/google-fonts/pkg-plist

Loading...