Page MenuHomeFreeBSD

Add port of latte-dock
ClosedPublic

Authored by adridg on Nov 13 2017, 11:23 PM.

Details

Summary

Latte-dock is an alternative launcher / task manager for Qt- and Plasma-
based desktops.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deskutils/latte-dock/Makefile
17 ↗(On Diff #35211)

^ line breaks

18 ↗(On Diff #35211)

I would prefer

USE_QT5= core dbus gui network qml quick widgets x11extras xml \
                 buildtools_build qmake_build
deskutils/latte-dock/Makefile
12 ↗(On Diff #35211)

I had this for the git-port of it:
LICENSE_FILE= ${WRKSRC}/COPYING

is the LICENSE file not present in the official release?

Line breaks, polish LICENSE data.

deskutils/latte-dock/Makefile
17 ↗(On Diff #35228)

^ according to portlint, you should invest in gettext stocks

deskutils/latte-dock/pkg-plist
2 ↗(On Diff #35228)

%%QT_QMLDIR%%/org/kde/latte/liblattedockplugin.so

adridg added inline comments.
deskutils/latte-dock/Makefile
17 ↗(On Diff #35228)

This is one of those weird cases where my portlint doesn't tell me that. And there was also sayonara, remember, where I added gettext-runtime (because of portlint) and then removed it later because it turned out ot be a false positive and something else was pulling it in already.

deskutils/latte-dock/Makefile
17 ↗(On Diff #35228)
-A          Turn on all additional checks.

-C          Pedantic committer flag.  This is equivalent to -abcmt.

Pet the human portlint. Update WWW to point to KDE.

Apart from that little += issue it's good to go.

deskutils/latte-dock/Makefile
15 ↗(On Diff #35370)

^= not +=

This revision is now accepted and ready to land.Nov 17 2017, 7:16 PM
This revision was automatically updated to reflect the committed changes.
head/deskutils/latte-dock/Makefile
6–7
MASTER_SITES=        KDE/stable/latte-dock

Don't use MASTER_SITE_SUBDIR.