New port: security/botan2: Portable, easy to use and efficient C++ crypto library

[yuri]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223199

[tcberner]

security/botan2/Makefile

8

PORTNAME=Botan and not setting this should work

[yuri]

security/botan2/Makefile

8

PORTNAME=Botan and not setting this should work

It would work, but IMO there's no point in making the port name capitalized.
Please look at xorg, apache, qt - all these are routinely capitalized when written in text, but port names aren't capitalized. botan is not any different.

I would tend to make PORTNAME capitalized when it has a special case of capitalization, like qTox, arXive, etc, not just routine one (when only the first letter is capitalized).

[tcberner]

security/botan2/files/patch-src_lib_prov_openssl_openssl__rsa.cpp

7

^ this could be upstreamed

[yuri]

security/botan2/files/patch-src_lib_prov_openssl_openssl__rsa.cpp

7

https://github.com/randombit/botan/pull/1290

[tcberner]

security/botan2/Makefile

8

Yes, but their distfile is not called "Xorg-server" :)

I don't mind either choice, so go with your gut

security/botan2/files/patch-src_lib_prov_openssl_openssl__rsa.cpp

7

good job

[yuri]

security/botan2/Makefile

8

On one hand, the previous (1.X) version uses 'botan': security/botan110
On the other hand, 'Botan' isn't how it is specifically marketed. It is 'Botan' only because the generic proper name capitalization rule is applied.
So I would choose 'botan'. :)

security/botan2/files/patch-src_lib_prov_openssl_openssl__rsa.cpp

7

Thanks!

[mat]

head/security/botan2/Makefile

41 ↗

(On Diff #35115)

This is bogus, obviously, but I wonder what it does, exactly.

I think it will generate an empty BROKEN_SSL variable, and maybe an openssl-devel variable containing openssl-devel.

It should be written as:

SSL_VARS=  BROKEN_SSL=openssl-devel

But, as BROKEN_SSL does not do anything unless you USES=ssl, simply write:

BROKEN_SSL=  openssl-devel