security/botan2/Makefile
8 ↗	(On Diff #35092)	PORTNAME=Botan and not setting this should work It would work, but IMO there's no point in making the port name capitalized. Please look at xorg, apache, qt - all these are routinely capitalized when written in text, but port names aren't capitalized. botan is not any different. I would tend to make PORTNAME capitalized when it has a special case of capitalization, like qTox, arXive, etc, not just routine one (when only the first letter is capitalized).

yuri retitled this revision from New port: Portable, easy to use and efficient C++ crypto library to New port: security/botan2: Portable, easy to use and efficient C++ crypto library.Nov 11 2017, 10:14 AM

yuri marked 2 inline comments as done.

tcberner added inline comments.Nov 11 2017, 1:38 PM

security/botan2/files/patch-src_lib_prov_openssl_openssl__rsa.cpp
7 ↗	(On Diff #35092)	^ this could be upstreamed

yuri marked an inline comment as done.Nov 11 2017, 4:11 PM

yuri added inline comments.

security/botan2/files/patch-src_lib_prov_openssl_openssl__rsa.cpp
7 ↗	(On Diff #35092)	https://github.com/randombit/botan/pull/1290

yuri marked 2 inline comments as done.Nov 11 2017, 4:27 PM

tcberner added inline comments.Nov 11 2017, 4:43 PM

security/botan2/Makefile
8 ↗	(On Diff #35092)	Yes, but their distfile is not called "Xorg-server" :) I don't mind either choice, so go with your gut
security/botan2/files/patch-src_lib_prov_openssl_openssl__rsa.cpp
7 ↗	(On Diff #35092)	good job

yuri marked 2 inline comments as done.Nov 11 2017, 5:11 PM

yuri added inline comments.

security/botan2/Makefile
8 ↗	(On Diff #35092)	On one hand, the previous (1.X) version uses 'botan': security/botan110 On the other hand, 'Botan' isn't how it is specifically marketed. It is 'Botan' only because the generic proper name capitalization rule is applied. So I would choose 'botan'. :)
security/botan2/files/patch-src_lib_prov_openssl_openssl__rsa.cpp
7 ↗	(On Diff #35092)	Thanks!

tcberner accepted this revision.Nov 11 2017, 6:06 PM

This revision is now accepted and ready to land.Nov 11 2017, 6:06 PM

Closed by commit rP453987: New port: security/botan2: Portable, easy to use and efficient C++ crypto… (authored by yuri). · Explain WhyNov 11 2017, 6:33 PM

This revision was automatically updated to reflect the committed changes.

yuri marked 2 inline comments as done.

mat added inline comments.Nov 24 2017, 4:44 PM

head/security/botan2/Makefile
41	This is bogus, obviously, but I wonder what it does, exactly. I think it will generate an empty `BROKEN_SSL` variable, and maybe an `openssl-devel` variable containing `openssl-devel`. It should be written as: SSL_VARS= BROKEN_SSL=openssl-devel But, as BROKEN_SSL does not do anything unless you USES=ssl, simply write: BROKEN_SSL= openssl-devel