New port: misc/unicode-emoji: Unicode emoji data files

[yuri]

Summary

New versions of IBus require this.

[yuri]

.

[tcberner]

misc/unicode-emoji/Makefile

7

I would add a DIST_SUBDIR=${PORTNAME}/${PORTVERSION} as the files themselves do not carry a version.

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-dist_subdir

[yuri]

Added DIST_SUBDIR.

[tcberner]

The two for-loops could probably be done more concise using variable modifiers ala

PLIST_FILES=${DISTFILES:S/^/share\/unicode\/emoji\/g}

but I think that would loose some readability :D

[yuri]

In D13011#270267, @tcberner wrote:

but I think that would loose some readability :D

I think so. :)

[tcberner]

misc/unicode-emoji/Makefile

18

maybe EXTRACT_ONLY= # nothing todo ?

[tcberner]

https://www.freebsd.org/doc/en/books/porters-handbook/book.html#5.4.6

[yuri]

In D13011#270271, @tcberner wrote:

https://www.freebsd.org/doc/en/books/porters-handbook/book.html#5.4.6

It says If only some of the DISTFILES must be extracted ..., and here we have no DISTFILES must be extracted, so it technically doesn't fall under this section. :-)
I am ok either way, but I feel do-extract version is marginally more readable. It explicitly says do nothing under the action.

[tcberner]

When none of the DISTFILES need to be uncompressed, set EXTRACT_ONLY to the empty string.

EXTRACT_ONLY=

[yuri]

Updated to EXTRACT_ONLY=

[tcberner]

misc/unicode-emoji/Makefile

22

^-${DISTDIR}/${DISTSUBDIR}

[yuri]

.

[tcberner]

Looks good to me.

[mat]

head/misc/unicode-emoji/Makefile

14 ↗

(On Diff #35081)

Didn't this line generate a warning ?

You must use BSD[234]CLAUSE and not BSD.

[yuri]

head/misc/unicode-emoji/Makefile

14 ↗

(On Diff #35081)

I will remove the license since nowhere on there site it says what the license is.

[yuri]

I am not sure what the LICENSE_PERMS actually are.

[yuri]

Not sure why this is here.