New port: multimedia/simplescreenrecorder: Screen video recorder

[yuri]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221168

[tcberner]

multimedia/simplescreenrecorder/Makefile

5

^ DISTVERSION

28

USE_GL, USE_QT4, USE_XORG

32

^ this is a Qt4-port, INSTALLS_ICONS is a gnome.mk feature.

52 # INSTALLS_ICONS    - If a GTK+ port installs Freedesktop-style icons to
53 #               ${LOCALBASE}/share/icons, then you should use this
54 #               macro. Using this macro ensures that icons are cached
55 #               and will display correctly. This macro isn't needed
56 #               for QT based applications, which use a different method.

35

PULSEAUDIO_CONFIGURE_WITH=pulseaudio is maybe more readable

38

JACK_CONFIGURE_WITH=jack is a bit more readble.

[mat]

multimedia/simplescreenrecorder/Makefile

24

So this is not 0.3.8 but:

$ git describe --tags 0f6eebf
0.3.8-26-g0f6eebf

[yuri]

GH_TAGNAME removed, DISTVERSIONSUFFIX added.

[mat]

multimedia/simplescreenrecorder/Makefile

18–19

As there are no other options, I don't really see the point of adding them in a single group, I think it will more or less be ignored anyway. Better do this:

OPTIONS_DEFINE= PULSEAUDIO JACK

18–20

Options should come later. See Chapter 14. Order of Variables in Port Makefiles.

38

Not only it is more readable, but the point is that we must not rely on 5.13.2. Feature Auto-Activation

[yuri]

Requested changes.

[yuri]

Updated.

[tcberner]

multimedia/simplescreenrecorder/files/patch-glinject_Hook.cpp

2

As a sidenote, this patch could probably be upstreamed?

[tcberner]

multimedia/simplescreenrecorder/Makefile

16

^you could sort these

multimedia/simplescreenrecorder/pkg-plist

65

^ those '%20' look rather "oopsie" :D -- unreleated ^^

[yuri]

multimedia/simplescreenrecorder/pkg-plist

65

I reported them upstream: https://github.com/MaartenBaert/ssr/issues/585

[yuri]

multimedia/simplescreenrecorder/files/patch-glinject_Hook.cpp

2

https://github.com/MaartenBaert/ssr/issues/586

[yuri]

Sorted.

[tcberner]

multimedia/simplescreenrecorder/files/patch-glinject_Hook.cpp

2

You could add the URL at the top of the patch file, that way one know that it is being upstreamed :)