New port: multimedia/simplescreenrecorder: Screen video recorder

[yuri]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221168

[tcberner]

multimedia/simplescreenrecorder/Makefile

4 ↗

(On Diff #34652)

^ DISTVERSION

27 ↗

(On Diff #34652)

USE_GL, USE_QT4, USE_XORG

31 ↗

(On Diff #34652)

^ this is a Qt4-port, INSTALLS_ICONS is a gnome.mk feature.

52 # INSTALLS_ICONS    - If a GTK+ port installs Freedesktop-style icons to
53 #               ${LOCALBASE}/share/icons, then you should use this
54 #               macro. Using this macro ensures that icons are cached
55 #               and will display correctly. This macro isn't needed
56 #               for QT based applications, which use a different method.

34 ↗

(On Diff #34652)

PULSEAUDIO_CONFIGURE_WITH=pulseaudio is maybe more readable

37 ↗

(On Diff #34652)

JACK_CONFIGURE_WITH=jack is a bit more readble.

[mat]

multimedia/simplescreenrecorder/Makefile

24 ↗

(On Diff #34655)

So this is not 0.3.8 but:

$ git describe --tags 0f6eebf
0.3.8-26-g0f6eebf

[yuri]

GH_TAGNAME removed, DISTVERSIONSUFFIX added.

[mat]

multimedia/simplescreenrecorder/Makefile

17–18 ↗

(On Diff #34781)

As there are no other options, I don't really see the point of adding them in a single group, I think it will more or less be ignored anyway. Better do this:

OPTIONS_DEFINE= PULSEAUDIO JACK

17–19 ↗

(On Diff #34781)

Options should come later. See Chapter 14. Order of Variables in Port Makefiles.

37 ↗

(On Diff #34652)

Not only it is more readable, but the point is that we must not rely on 5.13.2. Feature Auto-Activation

[yuri]

Requested changes.

[yuri]

Updated.

[tcberner]

multimedia/simplescreenrecorder/files/patch-glinject_Hook.cpp

1 ↗

(On Diff #34891)

As a sidenote, this patch could probably be upstreamed?

[tcberner]

multimedia/simplescreenrecorder/Makefile

15 ↗

(On Diff #34891)

^you could sort these

multimedia/simplescreenrecorder/pkg-plist

64 ↗

(On Diff #34891)

^ those '%20' look rather "oopsie" :D -- unreleated ^^

[yuri]

multimedia/simplescreenrecorder/pkg-plist

64 ↗

(On Diff #34891)

I reported them upstream: https://github.com/MaartenBaert/ssr/issues/585

[yuri]

multimedia/simplescreenrecorder/files/patch-glinject_Hook.cpp

1 ↗

(On Diff #34891)

https://github.com/MaartenBaert/ssr/issues/586

[yuri]

Sorted.

[tcberner]

multimedia/simplescreenrecorder/files/patch-glinject_Hook.cpp

1 ↗

(On Diff #34891)

You could add the URL at the top of the patch file, that way one know that it is being upstreamed :)