Page MenuHomeFreeBSD
Differential D12904

New port: audio/polyphone: Graphical user interface for editing soundfont (sf2 and sfz) files
ClosedPublic
Actions

Authored by yuri on Nov 2 2017, 4:24 AM.
Tags
None
Referenced Files
F133348136: D12904.id34651.diff
Sat, Oct 25, 2:41 AM
Unknown Object (File)
Mon, Oct 20, 12:35 AM
Unknown Object (File)
Sun, Oct 19, 1:37 PM
Unknown Object (File)
Sun, Oct 19, 9:27 AM
Unknown Object (File)
Sun, Oct 19, 7:56 AM
Unknown Object (File)
Sun, Oct 19, 3:38 AM
Unknown Object (File)
Wed, Oct 1, 1:54 PM
Unknown Object (File)
Mon, Sep 29, 5:45 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP453960: New port: audio/polyphone: Graphical user interface for editing soundfont (sf2…
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221400

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuri created this revision.Nov 2 2017, 4:24 AM
Herald added a subscriber: mat. · View Herald TranscriptNov 2 2017, 4:24 AM
tcberner added inline comments.Nov 2 2017, 6:04 AM
audio/polyphone/Makefile
26 ↗(On Diff #34651)

^ I think you can drop the '"'s

35 ↗(On Diff #34651)

If you switch to qmake:outsource you could probably drop this (would also mean using BUILD_WRKSRC below in the do-install).

yuri updated this revision to Diff 34657.Nov 2 2017, 6:21 AM
yuri marked 2 inline comments as done.
tcberner added inline comments.Nov 2 2017, 6:24 AM
audio/polyphone/Makefile
43 ↗(On Diff #34657)

INSTALL_WRKSRC should be correct

yuri updated this revision to Diff 34659.Nov 2 2017, 6:27 AM
yuri marked an inline comment as done.
mat added inline comments.Nov 2 2017, 2:58 PM
audio/polyphone/Makefile
7 ↗(On Diff #34659)
DISTVERSIONSUFFIX= -src
21 ↗(On Diff #34659)

keep this sorted, you may discover something.

22 ↗(On Diff #34659)

too early.

yuri marked 2 inline comments as done.Nov 2 2017, 3:34 PM
yuri updated this revision to Diff 34679.Nov 2 2017, 3:37 PM

Reviewers: tcberner, adamw

Harbormaster completed remote builds in B12399: Diff 34679.Nov 2 2017, 3:37 PM
yuri marked an inline comment as done.Nov 7 2017, 11:02 PM
tcberner added inline comments.Nov 10 2017, 8:38 PM
audio/polyphone/Makefile
15 ↗(On Diff #34679)

you could sort these some more

23 ↗(On Diff #34679)

you could move this above USE_QT5

yuri marked 2 inline comments as done.Nov 10 2017, 9:39 PM
yuri updated this revision to Diff 35057.Nov 10 2017, 9:43 PM

Requested changes.

tcberner added inline comments.Nov 10 2017, 10:00 PM
audio/Makefile
133 ↗(On Diff #35057)

careful ^ you got yor diffs mixed

tcberner added inline comments.Nov 10 2017, 10:01 PM
audio/Makefile
133 ↗(On Diff #35057)

sorry, the diff-of-the-diff was misleading

yuri marked 2 inline comments as done.Nov 10 2017, 10:08 PM
yuri added inline comments.
audio/Makefile
133 ↗(On Diff #35057)

I always check in meld before committing.
For the patches here I update them manually.

tcberner accepted this revision.Nov 11 2017, 8:14 AM

Looks good now.

This revision is now accepted and ready to land.Nov 11 2017, 8:14 AM
Closed by commit rP453960: New port: audio/polyphone: Graphical user interface for editing soundfont (sf2… (authored by yuri). · Explain WhyNov 11 2017, 8:32 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
audio/
1 line
polyphone/
50 lines
3 lines
files/
11 lines
14 lines
20 lines
6 lines

Diff 35088

View Options

head/audio/Makefile

Loading...
View Options

head/audio/polyphone/Makefile

Loading...
View Options

head/audio/polyphone/distinfo

Loading...
View Options

head/audio/polyphone/files/patch-sfark_sfarkextractor1.cpp

Loading...
View Options

head/audio/polyphone/files/polyphone.desktop

Loading...
View Options

head/audio/polyphone/files/polyphone.xml

Loading...
View Options

head/audio/polyphone/pkg-descr

Loading...