Page MenuHomeFreeBSD
Differential D12902

Re-added port: science/py-pymol: OpenGL based molecular visualization system (existed 2002/08/13-2014/09/01, deleted in r366862)
ClosedPublic
Actions

Authored by yuri on Nov 2 2017, 4:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 24 2024, 7:33 PM
Unknown Object (File)
Nov 21 2024, 5:34 PM
Unknown Object (File)
Nov 21 2024, 5:34 PM
Unknown Object (File)
Nov 21 2024, 5:34 PM
Unknown Object (File)
Nov 21 2024, 5:34 PM
Unknown Object (File)
Nov 21 2024, 5:34 PM
Unknown Object (File)
Nov 21 2024, 5:34 PM
Unknown Object (File)
Nov 21 2024, 5:34 PM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
adamw
Commits
rP456763: Re-added port: science/py-pymol: OpenGL based molecular visualization system…

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuri created this revision.Nov 2 2017, 4:01 AM
Herald added a subscriber: mat. · View Herald TranscriptNov 2 2017, 4:01 AM
yuri added a comment.Nov 2 2017, 4:03 AM

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218729

yuri updated this revision to Diff 34649.Nov 2 2017, 4:05 AM
tcberner added inline comments.Nov 2 2017, 6:12 AM
science/py-pymol/Makefile
8 ↗(On Diff #34649)

DISTVERSIONPREFIX=v

mat added inline comments.Nov 2 2017, 2:57 PM
science/py-pymol/Makefile
30 ↗(On Diff #34649)

add autoplist and drop pkg-plist.

yuri marked an inline comment as done.Nov 2 2017, 3:25 PM
yuri added inline comments.
science/py-pymol/Makefile
30 ↗(On Diff #34649)

autoplist is broken for this port, the note in code has the upstream bug number.

mat added a comment.Nov 2 2017, 3:45 PM

As this is a revive of the long gone biology/pymol (same upstream), do not add it as a new port but svn cp the old one and change the files in place.

tcberner added a comment.Nov 4 2017, 12:00 PM

@yuri here [ https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-qa-resurrect ] is described how you can do it.

yuri updated this revision to Diff 36633.Dec 15 2017, 6:00 PM
yuri marked an inline comment as done.

Updated the previously-deleted subversion revision from 2014.

Harbormaster completed remote builds in B13585: Diff 36633.Dec 15 2017, 6:00 PM
yuri added a comment.Dec 15 2017, 6:02 PM
In D12902#268632, @tcberner wrote:

@yuri here [ https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-qa-resurrect ] is described how you can do it.

@tcberner Sorry for the delay!

I updated the old revision with the new port files, and re-verified that everything is ok and it works.

yuri retitled this revision from New port: science/py-pymol: OpenGL based molecular visualization system to Re-added port: science/py-pymol: OpenGL based molecular visualization system (existed 2002/08/13-2014/09/01, deleted in r366862).Dec 15 2017, 6:04 PM
tcberner added a comment.Dec 15 2017, 6:06 PM

Don't forget MOVED

tcberner added inline comments.Dec 15 2017, 6:08 PM
science/py-pymol/Makefile
1 ↗(On Diff #36633)

^nope

tcberner added inline comments.Dec 15 2017, 6:10 PM
science/py-pymol/Makefile
9 ↗(On Diff #36633)

^DISTVERSIONPREFIX=v, should work

yuri added a comment.EditedDec 15 2017, 6:16 PM
In D12902#282282, @tcberner wrote:

Don't forget MOVED

For re-added ports, should the first column in MOVED be empty?

|science/py-pymol|2017-12-15|Re-added the previously-deleted on 2014/09/01 in r366862 port biology/pymol
yuri updated this revision to Diff 36634.Dec 15 2017, 6:20 PM

.

Harbormaster completed remote builds in B13586: Diff 36634.Dec 15 2017, 6:20 PM
yuri added a comment.Dec 15 2017, 6:23 PM
In D12902#282285, @yuri wrote:
In D12902#282282, @tcberner wrote:

Don't forget MOVED

For re-added ports, should the first column in MOVED be empty?

|science/py-pymol|2017-12-15|Re-added the previously-deleted on 2014/09/01 in r366862 port biology/pymol

Ah, MOVED should be deleted instead!

yuri updated this revision to Diff 36635.Dec 15 2017, 6:24 PM

.

Harbormaster completed remote builds in B13587: Diff 36635.Dec 15 2017, 6:24 PM
yuri marked 4 inline comments as done.Dec 16 2017, 6:17 PM
yuri updated this revision to Diff 36750.Dec 19 2017, 3:36 AM

.

yuri updated this revision to Diff 36751.Dec 19 2017, 3:42 AM

.

Harbormaster completed remote builds in B13656: Diff 36751.Dec 19 2017, 3:42 AM
adamw added a comment.Dec 19 2017, 4:49 AM

This port looks good, Yuri!

Have you resurrected a port yet? Show me the svn commands you'll use to re-add it. (Double-check your commands against https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-re-adding)

yuri added a comment.EditedDec 19 2017, 4:58 AM
In D12902#283137, @adamw wrote:

This port looks good, Yuri!

Have you resurrected a port yet? Show me the svn commands you'll use to re-add it. (Double-check your commands against https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-re-adding)

I already did the svn cp part locally. That's how it says it here, in phabricator:

biology/pymol
Copied to science/py-pymol
	
M			science/Makefile (1 line)	
P		(dir)	science/py-pymol/
Copied from biology/pymol

Now, in order to commit, I will use svn commit MOVED science/Makefile science/py-pymol.
This phase is very similar to a regular commit of a new port, plus one extra-file MOVED.
So the custom part is MOVED, I guess. One-line deletion there.

adamw accepted this revision.Dec 19 2017, 5:00 AM

If that svn cp was from the last known revision, it looks like you're good to go! Godspeed.

This revision is now accepted and ready to land.Dec 19 2017, 5:00 AM
Closed by commit rP456763: Re-added port: science/py-pymol: OpenGL based molecular visualization system… (authored by yuri). · Explain WhyDec 19 2017, 7:49 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
1 line
science/
1 line
py-pymol/
37 lines
3 lines
files/
34 lines
22 lines
9 lines
1002 lines

Diff 36775

View Options

head/MOVED

Loading...
View Options

head/science/Makefile

Loading...
View Options

head/science/py-pymol/Makefile

Loading...
View Options

head/science/py-pymol/distinfo

Loading...
View Options

head/science/py-pymol/files/patch-create__shadertext.py

Loading...
View Options

head/science/py-pymol/files/patch-setup.py

Loading...
View Options

head/science/py-pymol/pkg-descr

Loading...
View Options

head/science/py-pymol/pkg-plist

Loading...