Page MenuHomeFreeBSD

Re-added port: science/py-pymol: OpenGL based molecular visualization system (existed 2002/08/13-2014/09/01, deleted in r366862)
ClosedPublic

Authored by yuri on Nov 2 2017, 4:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 1:14 PM
Unknown Object (File)
Mar 5 2024, 1:42 PM
Unknown Object (File)
Mar 5 2024, 1:42 PM
Unknown Object (File)
Mar 5 2024, 1:39 PM
Unknown Object (File)
Mar 5 2024, 1:39 PM
Unknown Object (File)
Mar 5 2024, 1:39 PM
Unknown Object (File)
Mar 5 2024, 1:39 PM
Unknown Object (File)
Mar 5 2024, 1:39 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

science/py-pymol/Makefile
8 ↗(On Diff #34649)

DISTVERSIONPREFIX=v

science/py-pymol/Makefile
30 ↗(On Diff #34649)

add autoplist and drop pkg-plist.

yuri marked an inline comment as done.Nov 2 2017, 3:25 PM
yuri added inline comments.
science/py-pymol/Makefile
30 ↗(On Diff #34649)

autoplist is broken for this port, the note in code has the upstream bug number.

As this is a revive of the long gone biology/pymol (same upstream), do not add it as a new port but svn cp the old one and change the files in place.

yuri marked an inline comment as done.

Updated the previously-deleted subversion revision from 2014.

@tcberner Sorry for the delay!

I updated the old revision with the new port files, and re-verified that everything is ok and it works.

yuri retitled this revision from New port: science/py-pymol: OpenGL based molecular visualization system to Re-added port: science/py-pymol: OpenGL based molecular visualization system (existed 2002/08/13-2014/09/01, deleted in r366862).Dec 15 2017, 6:04 PM
science/py-pymol/Makefile
1 ↗(On Diff #36633)

^nope

science/py-pymol/Makefile
9 ↗(On Diff #36633)

^DISTVERSIONPREFIX=v, should work

Don't forget MOVED

For re-added ports, should the first column in MOVED be empty?

|science/py-pymol|2017-12-15|Re-added the previously-deleted on 2014/09/01 in r366862 port biology/pymol
In D12902#282285, @yuri wrote:

Don't forget MOVED

For re-added ports, should the first column in MOVED be empty?

|science/py-pymol|2017-12-15|Re-added the previously-deleted on 2014/09/01 in r366862 port biology/pymol

Ah, MOVED should be deleted instead!

yuri marked 4 inline comments as done.Dec 16 2017, 6:17 PM

This port looks good, Yuri!

Have you resurrected a port yet? Show me the svn commands you'll use to re-add it. (Double-check your commands against https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-re-adding)

This port looks good, Yuri!

Have you resurrected a port yet? Show me the svn commands you'll use to re-add it. (Double-check your commands against https://www.freebsd.org/doc/en_US.ISO8859-1/articles/committers-guide/ports.html#ports-qa-re-adding)

I already did the svn cp part locally. That's how it says it here, in phabricator:

biology/pymol
Copied to science/py-pymol
	
M			science/Makefile (1 line)	
P		(dir)	science/py-pymol/
Copied from biology/pymol

Now, in order to commit, I will use svn commit MOVED science/Makefile science/py-pymol.
This phase is very similar to a regular commit of a new port, plus one extra-file MOVED.
So the custom part is MOVED, I guess. One-line deletion there.

If that svn cp was from the last known revision, it looks like you're good to go! Godspeed.

This revision is now accepted and ready to land.Dec 19 2017, 5:00 AM
This revision was automatically updated to reflect the committed changes.