Page MenuHomeFreeBSD
Differential D12891

New port: audio/libmusicxml: Library and tools for the MusicXML format
ClosedPublic
Actions

Authored by yuri on Nov 1 2017, 8:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 9:52 PM
Unknown Object (File)
Sun, Nov 24, 2:53 PM
Unknown Object (File)
Tue, Nov 19, 4:03 PM
Unknown Object (File)
Tue, Nov 19, 4:03 PM
Unknown Object (File)
Tue, Nov 19, 4:03 PM
Unknown Object (File)
Tue, Nov 19, 4:03 PM
Unknown Object (File)
Tue, Nov 19, 4:03 PM
Unknown Object (File)
Tue, Nov 19, 4:02 PM
View All Files
Subscribers
dbaio
mat

Details

Reviewers
tcberner
adamw
Commits
rP453962: New port: audio/libmusicxml: Library and tools for the MusicXML format
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221861

The upstream doesn't make releases for a while. The version number 3.11 is from the shared library name.

MusicXML standard is the most widely used way to represent music notation. It is supported by several hundred software titles.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12598
Build 12873: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 1 2017, 8:41 AM
Herald added a subscriber: mat. · View Herald TranscriptNov 1 2017, 8:41 AM
yuri added a reviewer: adamw.Nov 1 2017, 9:05 AM
mat added inline comments.Nov 2 2017, 2:30 PM
audio/libmusicxml/Makefile
17

would be nice to ask upstream to create tags on releases so that you do not have to guesstimate which commit to use.

audio/libmusicxml/pkg-plist
51

This is not needed.

yuri marked an inline comment as done.Nov 2 2017, 2:52 PM
yuri added inline comments.
audio/libmusicxml/Makefile
17

I asked them in the bug on github.

dbaio added a subscriber: dbaio.Nov 2 2017, 6:14 PM
dbaio added inline comments.
audio/libmusicxml/Makefile
11

LICENSE must not contain MPL, instead use MPL[10|11|20].
MPL20 in this case.

yuri updated this revision to Diff 34690.Nov 2 2017, 7:56 PM
yuri marked an inline comment as done.
yuri edited the summary of this revision. (Show Details)

Fixed the license.

Harbormaster completed remote builds in B12407: Diff 34690.Nov 2 2017, 7:56 PM
yuri marked an inline comment as done.Nov 2 2017, 7:57 PM
yuri marked an inline comment as done.Nov 6 2017, 9:58 PM
tcberner added a comment.Nov 7 2017, 10:28 PM

This seems to be missing the

  • pkg-descr
  • distinfo

files

yuri updated this revision to Diff 34904.Nov 7 2017, 10:57 PM

Added missing files in patch.

Harbormaster completed remote builds in B12550: Diff 34904.Nov 7 2017, 10:57 PM
yuri updated this revision to Diff 34977.Nov 9 2017, 8:00 AM

Requested change.

Harbormaster completed remote builds in B12598: Diff 34977.Nov 9 2017, 8:00 AM
yuri marked an inline comment as done.Nov 9 2017, 8:00 AM
tcberner added inline comments.Nov 10 2017, 8:28 PM
audio/libmusicxml/Makefile
13

^ cmake:outsource

24

think about adding a patch instead of this -- you can for example use ${CMAKE_INSTALL_PREFIX} in the CMakeLists.txt.

yuri updated this revision to Diff 35075.Nov 10 2017, 11:37 PM

.

Harbormaster completed remote builds in B12639: Diff 35075.Nov 10 2017, 11:37 PM
yuri marked 2 inline comments as done.Nov 10 2017, 11:37 PM
tcberner accepted this revision.Nov 11 2017, 8:34 AM
This revision is now accepted and ready to land.Nov 11 2017, 8:34 AM
Closed by commit rP453962: New port: audio/libmusicxml: Library and tools for the MusicXML format (authored by yuri). · Explain WhyNov 11 2017, 8:38 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
audio/
1 line
34 lines
3 lines
5 lines
49 lines

Diff 34977

View Options

audio/Makefile

Loading...
View Options

audio/libmusicxml/

Loading...
View Options

audio/libmusicxml/Makefile

Loading...
View Options

audio/libmusicxml/distinfo

Loading...
View Options

audio/libmusicxml/pkg-descr

Loading...
View Options

audio/libmusicxml/pkg-plist

Loading...