efipart_strategy is using wrong offset with >512B sectors
ClosedPublic
Actions

Authored by tsoome on Oct 31 2017, 11:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 9, 9:08 PM

	Unknown Object (File)
	Tue, Apr 7, 3:22 AM

	Unknown Object (File)
	Thu, Mar 26, 3:59 AM

	Unknown Object (File)
	Tue, Mar 17, 5:45 AM

	Unknown Object (File)
	Sat, Mar 14, 4:13 PM

	Unknown Object (File)
	Sat, Mar 14, 3:26 PM

	Unknown Object (File)
	Feb 25 2026, 10:17 AM

	Unknown Object (File)
	Feb 24 2026, 3:27 AM

View All Files

Subscribers

None

Details

Reviewers

allanjude
imp
eric_metricspace.net

Commits

rS325286: efipart_strategy is using wrong offset with >512B sectors

Summary

The strategy() calls are assuming 512B sectors, so we need to adjust the
offset accordingly.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tsoome created this revision.Oct 31 2017, 11:53 AM

Harbormaster completed remote builds in B12326: Diff 34502.Oct 31 2017, 11:53 AM

imp accepted this revision.Oct 31 2017, 3:11 PM

imp added inline comments.

sys/boot/efi/libefi/efipart.c
880 ↗	(On Diff #34502)	why shift and not offset?

This revision is now accepted and ready to land.Oct 31 2017, 3:11 PM

offset is better name.

This revision now requires review to proceed.Oct 31 2017, 8:22 PM

imp accepted this revision.Oct 31 2017, 8:29 PM

This revision is now accepted and ready to land.Oct 31 2017, 8:29 PM

Closed by commit rS325286: efipart_strategy is using wrong offset with >512B sectors (authored by tsoome). · Explain WhyNov 1 2017, 6:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

efi/

libefi/

efipart.c

6 lines

Diff 34617

View Options

head/sys/boot/efi/libefi/efipart.c

efipart_strategy is using wrong offset with >512B sectorsClosedPublicActions