Page MenuHomeFreeBSD

loader ptblread() is broken with >512B sectors
ClosedPublic

Authored by tsoome on Oct 31 2017, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 2:17 AM
Unknown Object (File)
Mon, Sep 29, 12:18 PM
Unknown Object (File)
Sun, Sep 21, 11:15 PM
Unknown Object (File)
Aug 5 2025, 5:07 AM
Unknown Object (File)
Aug 4 2025, 2:24 AM
Unknown Object (File)
Jul 28 2025, 9:22 AM
Unknown Object (File)
Jul 27 2025, 12:38 PM
Unknown Object (File)
Jul 19 2025, 11:57 AM
Subscribers
None

Details

Summary

The loader strategy() function is assuming 512B blocks, so we need to adjust
ptblread() for other sector sizes.

Test Plan

use lsdev -v from loader OK prompt to confirm the partition table.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I will test this on my macbookpro NVMe where FreeBSD currently cannot read the partition table.

This looks good to me.... It will certainly be a NOP for 512 byte sectors.

This revision is now accepted and ready to land.Oct 31 2017, 3:10 PM
This revision now requires review to proceed.Oct 31 2017, 8:05 PM
This revision was automatically updated to reflect the committed changes.