Page MenuHomeFreeBSD

Always send STANDBY IMMEDIATE when shutting down
ClosedPublic

Authored by imp on Oct 26 2017, 6:49 PM.

Details

Summary

To save SMART data and for a drive to understand that it's been nicely
shutdown, we need to send a STANDBY IMMEDIATE. Modify adaspindown to
use a local CCB on the stack. When we're panicing, used
xpt_polled_action rather than cam_periph_runccb so that we can SEND
IMMEDIATE after we've shutdown the scheduler.

Sponsored by: Netflix

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp created this revision.Oct 26 2017, 6:49 PM
scottl accepted this revision.Oct 26 2017, 6:52 PM
This revision is now accepted and ready to land.Oct 26 2017, 6:52 PM
imp added inline comments.Oct 26 2017, 7:36 PM
sys/cam/ata/ata_da.c
3519 ↗(On Diff #34367)

This should be adaerror()

imp marked an inline comment as done.Oct 26 2017, 7:49 PM

Will fix the cosmetics before push.

This revision was automatically updated to reflect the committed changes.