Page MenuHomeFreeBSD
Differential D12782

native-xtools: Override proper NXBDESTDIR.
ClosedPublic
Actions

Authored by bdrewery on Oct 24 2017, 11:02 PM.
Tags
None
Referenced Files
F106142180: D12782.diff
Thu, Dec 26, 2:29 AM
Unknown Object (File)
Mon, Dec 9, 1:43 PM
Unknown Object (File)
Wed, Dec 4, 2:20 AM
Unknown Object (File)
Oct 9 2024, 8:05 PM
Unknown Object (File)
Oct 2 2024, 7:56 AM
Unknown Object (File)
Oct 2 2024, 7:55 AM
Unknown Object (File)
Oct 2 2024, 7:55 AM
Unknown Object (File)
Oct 2 2024, 7:45 AM
View All 34 Files
Subscribers
None

Details

Reviewers
imp
Commits
rS325000: native-xtools: Override proper NXBDESTDIR.
Summary

The new native-xtools uses 'make toolchain' so overriding DESTDIR
as a make argument may interfere with WORLDTMP handling.
The target also does a 'mkdir -p ${NXBDESTDIR}/usr', so we should
be modifying that rather than DESTDIR.

Note this causes the native-xtools binaries to be installed in
NANO_WORLDDIR/usr NANO_WORLDDIR/bin rather than NANO_WORLDDIR/nxb-bin/usr
and NANO_WORLDDIR/nxb-bin/bin. This was the case before this change
as well.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 12213
Build 12509: arc lint + arc unit

Event Timeline

bdrewery created this revision.Oct 24 2017, 11:02 PM
Harbormaster completed remote builds in B12213: Diff 34307.Oct 24 2017, 11:02 PM
bdrewery added a comment.Oct 24 2017, 11:12 PM

The "new" native-xtools is not yet committed but is at http://people.freebsd.org/~bdrewery/patches/native-xtools-new.diff

imp added a comment.Oct 24 2017, 11:27 PM

I believe this is fine. I need to do a full pass on all the changes to the build system by making all the images that used to work and testing them end-to-end on real hardware.

Closed by commit rS325000: native-xtools: Override proper NXBDESTDIR. (authored by bdrewery). · Explain WhyOct 25 2017, 9:46 PM
This revision was automatically updated to reflect the committed changes.
bdrewery added a comment.Oct 28 2017, 7:05 PM

I am going to revert this. I am adding a native-xtools-install and will pass in DESTDIR for it. This case is a bit unclear to me though. Did you intend to have the files installed in DESTDIR/usr/bin/* or DESTDIR/nxb-bin/usr/bin/* ?

imp added a comment.Oct 30 2017, 6:51 PM
In D12782#266099, @bdrewery wrote:

I am going to revert this. I am adding a native-xtools-install and will pass in DESTDIR for it. This case is a bit unclear to me though. Did you intend to have the files installed in DESTDIR/usr/bin/* or DESTDIR/nxb-bin/usr/bin/* ?

The intention was a separate tree, so the latter.

bdrewery added a comment.Oct 30 2017, 6:54 PM
In D12782#266099, @bdrewery wrote:

I am going to revert this. I am adding a native-xtools-install and will pass in DESTDIR for it. This case is a bit unclear to me though. Did you intend to have the files installed in DESTDIR/usr/bin/* or DESTDIR/nxb-bin/usr/bin/* ?

By revert I m

In D12782#266474, @imp wrote:
In D12782#266099, @bdrewery wrote:

I am going to revert this. I am adding a native-xtools-install and will pass in DESTDIR for it. This case is a bit unclear to me though. Did you intend to have the files installed in DESTDIR/usr/bin/* or DESTDIR/nxb-bin/usr/bin/* ?

The intention was a separate tree, so the latter.

K fixed in rS325163.

bdrewery mentioned this in rS325163: Fix native-xtools installion after r325082 and r325000 to be to /nxb-bin..Oct 30 2017, 6:54 PM

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
2 lines

Diff 34307

View Options

tools/tools/nanobsd/defaults.sh

Loading...