Massage sayonara USES

[adridg]

Summary

Massage sayonara USES

• when gstreamer1 plugins are missing, files just don't play (this applies also to, say, having a broken ogg plugin)
• complete the list of useful gstreamer plugins; while typical users will have -core installed, and thus -libav, make it explicit.
• drop gettext-runtime, it seems to have been an artifact of an unclean build. stage-qa doesn't ask for it on 10.4 or 12-.

Test Plan

Builds in host 10.4 and 12; poudriere 10.3.

[danfe]

audio/sayonara/Makefile

21 ↗

(On Diff #33839)

Let me review and verify this gettext-related change, might take some time as my building gear is somewhat slow.

24 ↗

(On Diff #33839)

Thanks for checking+fixing GStreamer plugins completeness. Please include (maybe revised) relevant part of this DR description in the commit log.

[danfe]

While it builds with gettext-runtime removed from the USES list, the resulting binary is still linked to libintl:

readelf -d /tmp/sayonara | grep libintl
 0x00000001 NEEDED               Shared library: [libintl.so.8]

Apparently, stage-qa does not complain about it because it is pulled into LIB_DEPENDS due to USES_GNOME=glib20, that is, via Mk/Uses/gnome.mk (see the entry glib20_LIB_DEPENDS). If you temporarily comment libintl.so:devel/gettext-runtime out from it, the port would still build because other dependencies still require this library, but now stage-qa would start suggesting to put gettext-runtime back on the USES list.

I personally do not have a strong opinion on this whole direct vs. indirect dependencies issue; I'm happy with either way as long as all needed libraries are pulled in and found during configure/build of the software in question.

[danfe]

Actually, my last closing statement about direct vs. indirect dependencies does not really apply here: because of USES_GNOME=glib20, direct dependency on libintl.so is recorded as it should; putting gettext-runtime onto the USES list simply means that it will appear on the resulting LIB_DEPENDS list twice.

That said, I guess it makes sense to drop it from USES; if any time in the future pulling glib20 via our Gnome support framework would stop pulling libintl.so as well, stage-qa warning would remind one to use the USES list again.

However, shall you decide to drop it, please do not bogusly suggest that it seems to have been an artifact of an unclean build; stage-qa doesn't ask for it on 10.4 or 12- but give a proper explanation instead.