Page MenuHomeFreeBSD

Update audio/sayonara to 0.9.3 and take maintainership
ClosedPublic

Authored by adridg on Oct 6 2017, 7:45 AM.
Tags
None
Referenced Files
F132677526: D12601.id33743.diff
Sat, Oct 18, 11:47 PM
F132641046: D12601.id33816.diff
Sat, Oct 18, 4:31 PM
Unknown Object (File)
Fri, Oct 17, 1:29 AM
Unknown Object (File)
Sun, Oct 12, 5:43 AM
Unknown Object (File)
Thu, Oct 9, 6:07 AM
Unknown Object (File)
Tue, Sep 30, 11:15 AM
Unknown Object (File)
Tue, Sep 30, 7:13 AM
Unknown Object (File)
Tue, Sep 30, 5:42 AM
Subscribers

Details

Summary

Update audio/sayonara to 0.9.3 and take maintainership; adjust to
CMake 3.9.

Test Plan

Builds, runs, plays music on 10.4 amd64.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

audio/sayonara/Makefile
8 ↗(On Diff #33738)

Can't you use DISTVERSIONSUFFIX?

19 ↗(On Diff #33738)

Use cmake:outsource if it allows it

23 ↗(On Diff #33738)

This is a gnome.mk feature -- likely not needed.

audio/sayonara/Makefile
5 ↗(On Diff #33743)

Maybe think about renameing the port to sayonara-player in the future?

Looks good to me (10@32 and 12@64).

This revision is now accepted and ready to land.Oct 6 2017, 9:05 PM
This revision was automatically updated to reflect the committed changes.