Page MenuHomeFreeBSD
Differential D12601

Update audio/sayonara to 0.9.3 and take maintainership
ClosedPublic
Actions

Authored by adridg on Oct 6 2017, 7:45 AM.
Tags
None
Referenced Files
F168761590: D12601.id33738.diff
Sun, Aug 30, 12:48 AM
Unknown Object (File)
Wed, Aug 26, 5:39 PM
Unknown Object (File)
Wed, Aug 26, 3:10 PM
Unknown Object (File)
Wed, Aug 26, 3:08 PM
Unknown Object (File)
Tue, Aug 25, 4:10 PM
Unknown Object (File)
Tue, Aug 25, 1:28 PM
Unknown Object (File)
Tue, Aug 25, 11:16 AM
Unknown Object (File)
Mon, Aug 24, 7:33 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
rakuco
Commits
rP451527: Update audio/sayonara to 0.9.3 and take maintainership.
Summary

Update audio/sayonara to 0.9.3 and take maintainership; adjust to
CMake 3.9.

Test Plan

Builds, runs, plays music on 10.4 amd64.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adridg created this revision.Oct 6 2017, 7:45 AM
Herald added a subscriber: mat. · View Herald TranscriptOct 6 2017, 7:45 AM
tcberner added inline comments.Oct 6 2017, 7:52 AM
audio/sayonara/Makefile
8 ↗(On Diff #33738)

Can't you use DISTVERSIONSUFFIX?

19 ↗(On Diff #33738)

Use cmake:outsource if it allows it

23 ↗(On Diff #33738)

This is a gnome.mk feature -- likely not needed.

adridg updated this revision to Diff 33743.Oct 6 2017, 11:08 AM

Address comments

adridg marked 3 inline comments as done.Oct 6 2017, 11:09 AM
tcberner added inline comments.Oct 6 2017, 8:18 PM
audio/sayonara/Makefile
5 ↗(On Diff #33743)

Maybe think about renameing the port to sayonara-player in the future?

tcberner accepted this revision.Oct 6 2017, 9:05 PM

Looks good to me (10@32 and 12@64).

This revision is now accepted and ready to land.Oct 6 2017, 9:05 PM
Closed by commit rP451527: Update audio/sayonara to 0.9.3 and take maintainership. (authored by adridg). · Explain WhyOct 8 2017, 1:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33816

View Options

head/audio/sayonara/Makefile

Loading...
View Options

head/audio/sayonara/distinfo

Loading...
View Options

head/audio/sayonara/files/patch-CMakeLists.txt

Loading...
View Options

head/audio/sayonara/files/patch-src_3rdParty_SomaFM_ui_GUI__SomaFM.h

Loading...
View Options

head/audio/sayonara/files/patch-src_3rdParty_Soundcloud_ui_GUI__SoundcloudArtistSearch.h

Loading...
View Options

head/audio/sayonara/files/patch-src_3rdParty_Soundcloud_ui_GUI__SoundcloudLibrary.h

Loading...
View Options

head/audio/sayonara/files/patch-src_CMakeLists.txt

Loading...
View Options

head/audio/sayonara/files/patch-src_Helper_Logger_Logger.h

Loading...
View Options

head/audio/sayonara/files/patch-src_Main.cpp

Loading...
View Options

head/audio/sayonara/files/patch-uifiles.patch

Loading...
View Options

head/audio/sayonara/pkg-plist

Loading...