Page MenuHomeFreeBSD

Update audio/sayonara to 0.9.3 and take maintainership
ClosedPublic

Authored by adridg on Oct 6 2017, 7:45 AM.
Tags
None
Referenced Files
F174769006: D12601.id33743.diff
Mon, Oct 5, 9:17 PM
F174768558: D12601.id33816.diff
Mon, Oct 5, 9:13 PM
F174768136: D12601.id33738.diff
Mon, Oct 5, 9:08 PM
Unknown Object (File)
Mon, Oct 5, 10:31 AM
Unknown Object (File)
Fri, Sep 18, 4:24 PM
Unknown Object (File)
Thu, Sep 17, 9:20 PM
Unknown Object (File)
Wed, Sep 16, 4:30 PM
Unknown Object (File)
Tue, Sep 15, 10:02 AM
Subscribers

Details

Summary

Update audio/sayonara to 0.9.3 and take maintainership; adjust to
CMake 3.9.

Test Plan

Builds, runs, plays music on 10.4 amd64.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

audio/sayonara/Makefile
8 ↗(On Diff #33738)

Can't you use DISTVERSIONSUFFIX?

19 ↗(On Diff #33738)

Use cmake:outsource if it allows it

23 ↗(On Diff #33738)

This is a gnome.mk feature -- likely not needed.

audio/sayonara/Makefile
5 ↗(On Diff #33743)

Maybe think about renameing the port to sayonara-player in the future?

Looks good to me (10@32 and 12@64).

This revision is now accepted and ready to land.Oct 6 2017, 9:05 PM
This revision was automatically updated to reflect the committed changes.