Page MenuHomeFreeBSD

Update audio/sayonara to 0.9.3 and take maintainership
ClosedPublic

Authored by adridg on Oct 6 2017, 7:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 7, 11:02 AM
Unknown Object (File)
Fri, Jun 7, 11:02 AM
Unknown Object (File)
Fri, Jun 7, 11:02 AM
Unknown Object (File)
Fri, Jun 7, 11:02 AM
Unknown Object (File)
Thu, Jun 6, 7:52 AM
Unknown Object (File)
Mon, May 20, 12:35 AM
Unknown Object (File)
Apr 27 2024, 4:53 PM
Unknown Object (File)
Apr 19 2024, 1:03 PM
Subscribers

Details

Summary

Update audio/sayonara to 0.9.3 and take maintainership; adjust to
CMake 3.9.

Test Plan

Builds, runs, plays music on 10.4 amd64.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

audio/sayonara/Makefile
8 ↗(On Diff #33738)

Can't you use DISTVERSIONSUFFIX?

19 ↗(On Diff #33738)

Use cmake:outsource if it allows it

23 ↗(On Diff #33738)

This is a gnome.mk feature -- likely not needed.

audio/sayonara/Makefile
5 ↗(On Diff #33743)

Maybe think about renameing the port to sayonara-player in the future?

Looks good to me (10@32 and 12@64).

This revision is now accepted and ready to land.Oct 6 2017, 9:05 PM
This revision was automatically updated to reflect the committed changes.