bnxt: intermittently VLAN ping doesn't work
ClosedPublic
Actions

Authored by bhargava.marreddy_broadcom.com on Sep 28 2017, 10:55 AM.

Details

Reviewers

siva.kallam_broadcom.com
shurd
sbruno

Commits

rS324323: bnxt: fix intermittent VLAN issues

Summary

bnxt_init() is invokes Function Reset (bnxt_hwrm_func_reset) and thus FW configuration for VLANs get erased.
To fix this, in bnxt_init(), Invoking HWRM to configure VLANs (bnxt_hwrm_cfa_l2_set_rx_mask).

Test Plan

VLAN I/O

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bhargava.marreddy_broadcom.com created this revision.Sep 28 2017, 10:55 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 28 2017, 10:55 AM

Looks good to me.

This revision is now accepted and ready to land.Oct 5 2017, 4:24 PM

stlgtm

Closed by commit rS324323: bnxt: fix intermittent VLAN issues (authored by shurd). · Explain WhyOct 5 2017, 5:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

bnxt/

if_bnxt.c

1 line

Diff 33723

View Options

head/sys/dev/bnxt/if_bnxt.c

bnxt: intermittently VLAN ping doesn't work ClosedPublicActions