Page MenuHomeFreeBSD

devel/gdb: Updating to gdb 8.0.1
ClosedPublic

Authored by pizzamig on Sep 28 2017, 9:40 AM.

Details

Summary

devel/gdb: Updating to gdb 8.0.1
Resolving tons of warning
Fixing the type of literal string as char const *
Fixing variables order and adding the license file
Making portlint happy

Reviewd by\: jhb
Approved by\: olivier (mentor)
Approved by\: lme (mentor)

Test Plan

porlint happy
Built on 10.3 11.0 11.1 on i386 and amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

pizzamig created this revision.Sep 28 2017, 9:40 AM

Lot's of patch files were renamed with a special name: Is this correct ?

Lot's of patch files were renamed with a special name: Is this correct ?

I renamed the patches to follow the General Rules for Patching (Paragraph 4.4.1 of the Porters Handbook). Moreover, portlint reported 17 warnings, caused by the "wrong" patch format.
I hope I fixed it correctly.

jhb accepted this revision.Sep 28 2017, 6:30 PM
jhb added inline comments.
devel/gdb/Makefile
15 ↗(On Diff #33522)

We could updated this comment to say "untested on sparc64, might work" as that's the only architecture where that is true.

This revision is now accepted and ready to land.Sep 28 2017, 6:30 PM
pizzamig updated this revision to Diff 33554.Sep 29 2017, 10:01 AM

Rephrasing the comment about supported architecture

This revision now requires review to proceed.Sep 29 2017, 10:01 AM
pizzamig marked an inline comment as done.Sep 29 2017, 10:02 AM
lme accepted this revision.Sep 29 2017, 11:38 AM
This revision is now accepted and ready to land.Sep 29 2017, 11:38 AM
This revision was automatically updated to reflect the committed changes.