Add my author entity
ClosedPublic
Actions

Authored by ygy on Sep 24 2017, 5:31 AM.

Details

Reviewers

loader
delphij

Commits

rD50912: Reviewed by: loader (mentor), emaste

Summary

Following "Setup, Conventions & Traditions" in the Committer's Guide, I added my author entity, updated the list of developers, added a news item, and added my PGP keys.

I am fairly new to SVN as well, so please let me know if the diff should be modified/improved. I would also like to know if the following commit message is appropriate: (Tabs are used, underscores will be removed)

Reviewed_by: loader (mentor)
Approved_by: loader (mentor)
Differential_Revision: https://reviews.freebsd.org/D1XXXX

Diff Detail

Repository

rD FreeBSD doc repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ygy created this revision.Sep 24 2017, 5:31 AM

ygy added a subscriber: emaste.

loader accepted this revision.Sep 24 2017, 9:06 AM

This revision is now accepted and ready to land.Sep 24 2017, 9:06 AM

One comment from https://wiki.freebsd.org/Phabricator - for future reviews please create diffs with full context as it makes review easier in the UI. One of:

git diff -U999999 other-branch
svn diff --diff-cmd=diff -x -U999999

Closed by commit rD50912: Reviewed by: loader (mentor), emaste (authored by ygy). · Explain WhySep 24 2017, 10:44 AM

This revision was automatically updated to reflect the committed changes.

In D12481#258714, @emaste wrote:
One comment from https://wiki.freebsd.org/Phabricator - for future reviews please create diffs with full context as it makes review easier in the UI. One of:
git diff -U999999 other-branch
svn diff --diff-cmd=diff -x -U999999

Thank you @emaste and @loader , I just made my first commit! Sorry that I even forgot to add a formal commit message before the "Reviewed by" section, I guess I cannot change it anymore. Will pay attention next time!