Page MenuHomeFreeBSD

bnxt: Enable support to run as a guest driver on VF attached VM
ClosedPublic

Authored by siva.kallam_broadcom.com on Sep 19 2017, 4:57 AM.

Details

Summary
  1. Added support to issue HWRM_FUNC_VF_CFG if driver running with VF
  2. Corrected logic to find VF or NPAR
  3. Cleaned and Consolidated BNXT flags
  4. Added additional check for WoL enable
Test Plan

Ran sanity tests as VF driver on both ESXi and Linux Hyper visors.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sys/dev/bnxt/bnxt_hwrm.c
953 ↗(On Diff #33211)

Possibly this function should be renamed or split?

The implication of bnxt_hwrm_func_cfg() is that it calls HWRM_FUNC_CFG. Maybe bnxt_cfg_async_cr()? Or split into bnxt_hwrm_func_cfg() and bnxt_hwrm_func_vf_cfg() and have the caller choose the correct function?

siva.kallam_broadcom.com added inline comments.
sys/dev/bnxt/bnxt_hwrm.c
953 ↗(On Diff #33211)

OK. Will modify it as bnxt_cfg_async_cr().

This revision is now accepted and ready to land.Sep 19 2017, 8:57 AM

Renamed bnxt_hwrm_func_cfg to bnxt_cfg_async_cr as later one is more appropriate.

This revision now requires review to proceed.Sep 19 2017, 9:13 AM
This revision is now accepted and ready to land.Sep 19 2017, 5:02 PM

Since there's no real way to test this on FreeBSD at the moment ...

stlgtm

This revision was automatically updated to reflect the committed changes.