Page MenuHomeFreeBSD

Force linking of `libperl.so` with all shared modules.
AbandonedPublic

Authored by mat on Nov 27 2014, 3:32 PM.

Details

Reviewers
swills
bdrewery
mat
Group Reviewers
portmgr
Perl

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage

Event Timeline

mat retitled this revision from to Force linking of `libperl.so` with all shared modules..
mat updated this object.
mat edited the test plan for this revision. (Show Details)

add other perl's to the mix

mat added a subscriber: Unknown Object (MLST).Dec 2 2014, 11:20 PM

Add a bit of qa.sh

mat edited edge metadata.

be sure to match libperl missing

bdrewery requested changes to this revision.Dec 5 2014, 4:42 PM
bdrewery added a reviewer: bdrewery.
bdrewery added a subscriber: bdrewery.
bdrewery added inline comments.
Mk/Scripts/qa.sh
219

You'll need to return 1 for this case, but not you can't without refactoring or using a temp file since this is in a subshell/pipe.

This revision now requires changes to proceed.Dec 5 2014, 4:42 PM
mat edited edge metadata.

Also, if you use err, you need to return 1

mat edited edge metadata.

Install libperl as libperl.so.x.yy.z and have its soname be libperl.so.x.

Also, fix the libperl to only run when really needed stage-qa check.

Do not hardcode SHRPLDFLAGS in libperl.so's target.

antoine added inline comments.
Mk/Scripts/qa.sh
212

Here I think you need to put this:

  1. No results presents a blank line [ -z "${f}" ] && continue

(otherwise there will be like 5000 qa errors!)

Handle find not getting any .so and the heredoc having an empty line.

Fixup the libperl qa to only err if none of the .so are linked with libperl.so.

mat added a reviewer: mat.
swills added a reviewer: swills.
swills added a subscriber: swills.

I like the idea. Haven't looked at the code too closely, but it is a shame perl doesn't do this.