Page MenuHomeFreeBSD

www/gitlab: Add support for reverse proxies in rc script
AbandonedPublic

Authored by ultima on Sep 15 2017, 1:35 AM.

Details

Summary
  • Add support for reverse proxies in rc script
  • Cleanup rc script

Reviewed by\: lifanov (mentor), matthew (mentor), tz (maintainer)
Approved by\: lifanov (mentor), matthew (mentor), tz (maintainer)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
WARN: Makefile: new ports should not set PORTREVISION.
WARN: Makefile: "BUILD_DEPENDS" has to appear earlier.
WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
0 fatal errors and 4 warnings found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 11577
Build 11930: arc lint + arc unit

Event Timeline

ultima created this revision.Sep 15 2017, 1:35 AM
lifanov accepted this revision.Sep 15 2017, 2:26 AM

Looks good! Make sure you also get maintainer's approval.

This revision is now accepted and ready to land.Sep 15 2017, 2:26 AM
tz added a comment.Nov 16 2017, 10:54 AM

Hello ultima,
sorry i took so long to respond. But finally :)
General your change looks good to me. But there is one catch for me: i try to stay as near as possible to the file provided by GitLab itself. Changes of this values are very time-consuming to migrate. Therefore it would be better to get your change into upstream (or did you take it from a newer version?) and than get it afterwards into the port.
There is currently a update to 10.1.3 ready and just waits for some dependencies to be committed :)
Greetings,
Torsten

ultima abandoned this revision.Nov 16 2017, 5:49 PM
In D12376#272695, @tz wrote:

Hello ultima,
sorry i took so long to respond. But finally :)
General your change looks good to me. But there is one catch for me: i try to stay as near as possible to the file provided by GitLab itself. Changes of this values are very time-consuming to migrate. Therefore it would be better to get your change into upstream (or did you take it from a newer version?) and than get it afterwards into the port.
There is currently a update to 10.1.3 ready and just waits for some dependencies to be committed :)
Greetings,
Torsten

Hey, no problem take your time. One of the updates actually caused the reverse proxy to stop working altogether. I never had time to figure out why. Going to drop this for now. When/if I get back to it i'll work with upstream first to get it pushed in.

Thanks,
Richard Gallamore