Add USE_GITLAB documentation with examples
Reviewed by\: lifanov (mentor), matthew (mentor), docscommitter
Approved by\: lifanov (mentor), matthew (mentor), docscommitter
Differential Revision\: https://reviews.freebsd.org/DXXXXX
Differential D12261
Add USE_GITLAB documentation ultima on Sep 6 2017, 9:02 PM. Authored by Tags None Referenced Files
Details
Add USE_GITLAB documentation with examples Reviewed by\: lifanov (mentor), matthew (mentor), docscommitter
Diff Detail
Event TimelineComment Actions As this is a commit against the docs repo, you don't need approval from Nikolai or me, but you will need approval from someone with a docs commit bit. Comment Actions Ah, okay. I thought all commits required mentor approval, so this means only the case under the commit bit type. Comment Actions If you are being mentored, all commits require your mentors approval, wherever the commit goes. Comment Actions Its no problem, take your time. This isn't a small change that is easily glanced at afterall.
Comment Actions Thanks for taking a look mat, trust me I'm not trying to mask the fact that some/part/most of the docs were copied then modified instead of created from scratch. These areas are still a bit above my skill level and it will definitely take some time before I get to the point of writing from zero. I'v been a bit busy lately with interviewing / studying and such, will try and get to the corrections on the weekend, and also submit the correct for GitHub if I have the time. Comment Actions Well, I would not have noticed you copied stuff if not for phabricator's little orange tab at the start of the line saying "copied from line xxx" :-)
Sure, no rush.
|