usr.bin/netstat: don't call kresolve_list() if using live kernel
ClosedPublic
Actions

Authored by nikita_elyzion.net on Aug 29 2017, 1:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 25, 8:23 PM

	Unknown Object (File)
	Fri, Nov 21, 6:00 PM

	Unknown Object (File)
	Fri, Nov 21, 12:37 AM

	Unknown Object (File)
	Fri, Nov 21, 12:36 AM

	Unknown Object (File)
	Fri, Nov 21, 12:31 AM

	Unknown Object (File)
	Fri, Nov 21, 12:30 AM

	Unknown Object (File)
	Sun, Nov 16, 11:08 PM

	Unknown Object (File)
	Sun, Nov 16, 9:26 PM

View All Files

Subscribers

imp

Details

Reviewers

bapt
cem

Commits

rS323666: MFC r323016:
rS323016: Don't call kresolv_list() if using netstat on live kernel

Summary

kresolve_list() is doing 372 kldsym() calls in my tests for a simple netstat.
Calling it only for non-live image improves the running time and CPU usage when collecting stats for the running kernel.

Note: I tested it only on stable/11

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nikita_elyzion.net created this revision.Aug 29 2017, 1:42 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 29 2017, 1:42 PM

cem accepted this revision.Aug 29 2017, 3:04 PM

This revision is now accepted and ready to land.Aug 29 2017, 3:04 PM

Closed by commit rS323016: Don't call kresolv_list() if using netstat on live kernel (authored by bapt). · Explain WhyAug 30 2017, 7:58 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.bin/

netstat/

main.c

5 lines

Diff 32514

View Options

head/usr.bin/netstat/main.c

usr.bin/netstat: don't call kresolve_list() if using live kernelClosedPublicActions