Page MenuHomeFreeBSD

www/qt5-webkit: Ensure qconfig-modules.h does not include qconfig-webkit.h
ClosedPublic

Authored by rakuco on Aug 26 2017, 12:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 22, 8:27 AM
Unknown Object (File)
Tue, Sep 30, 2:19 PM
Unknown Object (File)
Sep 13 2025, 3:27 AM
Unknown Object (File)
Sep 12 2025, 10:23 PM
Unknown Object (File)
Sep 12 2025, 10:06 PM
Unknown Object (File)
Sep 4 2025, 4:58 AM
Unknown Object (File)
Sep 3 2025, 10:15 PM
Unknown Object (File)
Aug 27 2025, 1:47 PM
Subscribers

Details

Reviewers
tcberner
adridg
rakuco
Group Reviewers
kde
Summary

rP448361 updated Qt WebKit and dropped QT_DIST and QT_DEFINES, which led to existing installations being upgraded to remove qconfig-webkit.h while not removing the corresponding #include <QtCore/modules/qconfig-webkit.h> from qconfig-modules.h.

Consequently, any build that uses the Qt5 ports (i.e. building a port locally, or any project using Qt5) fails with errors like:

/usr/local/include/qt5/QtCore/qconfig-modules.h:8:10: fatal error: 'QtCore/modules/qconfig-webkit.h' file not found
Test Plan

Building a program using Qt5 worked fine again.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Looks sensible to me, although I don't understand SUB_FILES and pkg-install shell scripts well enough to say "do it".

Looks good to me.

www/qt5-webkit/files/pkg-install.in
5

^ typo in qconfi-modules.h

Landed in rP448821, I forgot to mention the Phab link in the commit message :(

This revision is now accepted and ready to land.Aug 27 2017, 2:07 PM