Page MenuHomeFreeBSD
Differential D12128

bnxt: Use correct firmware ioctl to get number of Rx/Tx queues supported by firmware
ClosedPublic
Actions

Authored by bhargava.marreddy_broadcom.com on Aug 26 2017, 11:30 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 10:23 PM
Unknown Object (File)
Mon, Nov 11, 3:54 AM
Unknown Object (File)
Oct 11 2024, 8:26 AM
Unknown Object (File)
Sep 17 2024, 2:40 AM
Unknown Object (File)
Sep 12 2024, 9:16 AM
Unknown Object (File)
Sep 11 2024, 4:03 PM
Unknown Object (File)
Sep 10 2024, 10:53 PM
Unknown Object (File)
Sep 9 2024, 10:50 PM
View All 53 Files
Subscribers
imp

Details

Reviewers
venkatkumar.duvvuru_broadcom.com
siva.kallam_broadcom.com
shurd
sbruno
Commits
rS323232: bnxt: Use correct firmware call for number of queues supported
Summary
  1. Based on the suggestion from firmware team, derive scctx->isc_ntxqsets_max & scctx->isc_nrxqsets_max based on FUNC_QCFG (instead of FUNC_QCAPS).
  2. Bump-up driver version to "1.0.0.2".

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bhargava.marreddy_broadcom.com created this revision.Aug 26 2017, 11:30 AM
Herald added a subscriber: imp. · View Herald TranscriptAug 26 2017, 11:30 AM
shurd requested changes to this revision.Aug 26 2017, 4:40 PM
shurd added inline comments.
sys/dev/bnxt/bnxt.h
541 ↗(On Diff #32405)

If only four of these values are being used, they don't all need to be in the softc.

sys/dev/bnxt/bnxt_hwrm.c
486 ↗(On Diff #32405)

All of these values except the MACs and other network fields need to be converted to host byte order.

This revision now requires changes to proceed.Aug 26 2017, 4:40 PM
shurd added inline comments.Aug 26 2017, 4:46 PM
sys/dev/bnxt/if_bnxt.c
779 ↗(On Diff #32405)

Why is making the max TX and max RX the same value desirable? Users can request that TX and RX have different nrxqs via the dev.bnxt.X..iflib.override_qs_enable sysctl.

If a VF is allocated a small number of one ring type, but a large number of the other, this will result in not being able to use the allocated resources.

bhargava.marreddy_broadcom.com added inline comments.Aug 26 2017, 5:09 PM
sys/dev/bnxt/bnxt.h
541 ↗(On Diff #32405)

Thought of using them in future for display / other way.
Sure!! I'll delete unused ones now .

sys/dev/bnxt/bnxt_hwrm.c
486 ↗(On Diff #32405)

Thanks, I'll fix it!!

sys/dev/bnxt/if_bnxt.c
779 ↗(On Diff #32405)

Only reason based on my experience with other 10G/40G drivers is - having same number of Rx & Tx queues works well for features like "Queue pairing" etc..
Thanks for pointing me to dev.bnxt.X..iflib.override_qs_enable, Can I remove that 'same number' restriction?

shurd added inline comments.Aug 26 2017, 5:17 PM
sys/dev/bnxt/if_bnxt.c
779 ↗(On Diff #32405)

By default, iflib will allocate equal numbers of queues. This variable is intended to be the max supported by the hardware, not the suggested value.

bhargava.marreddy_broadcom.com updated this revision to Diff 32413.Aug 26 2017, 6:02 PM
bhargava.marreddy_broadcom.com edited edge metadata.
bhargava.marreddy_broadcom.com marked an inline comment as done.

Thanks Stephen!! Taken care of your review comments.

shurd accepted this revision.Aug 27 2017, 4:25 PM

Looks good to me

This revision is now accepted and ready to land.Aug 27 2017, 4:25 PM
bhargava.marreddy_broadcom.com added a comment.Aug 29 2017, 2:30 PM

Sean Bruno,

If there are no further review comments, can you please commit this change,

Thanks,
Chenna.

sys/dev/bnxt/if_bnxt.c
779 ↗(On Diff #32405)

Understood!! I'll do the change.

shurd added a comment.Aug 29 2017, 9:05 PM

You should update the summary to remove item #2 so it's useful as a commit message.

bhargava.marreddy_broadcom.com edited the summary of this revision. (Show Details)Aug 31 2017, 2:48 PM

You should update the summary to remove item #2 so it's useful as a commit message.

<Chenna> Done!!

Sean Bruno,

If there are no further review comments, can you please commit this change,

sbruno accepted this revision.Sep 6 2017, 5:37 PM
Closed by commit rS323232: bnxt: Use correct firmware call for number of queues supported (authored by shurd). · Explain WhySep 6 2017, 8:14 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
bnxt/
8 lines
1 line
25 lines
21 lines

Diff 32745

View Options

head/sys/dev/bnxt/bnxt.h

Loading...
View Options

head/sys/dev/bnxt/bnxt_hwrm.h

Loading...
View Options

head/sys/dev/bnxt/bnxt_hwrm.c

Loading...
View Options

head/sys/dev/bnxt/if_bnxt.c

Loading...