Patch contrib/libpcap 1.8 to fix builds

[feld]

Summary

A bug in libpcap 1.8 branch causes any software that defines HAVE_REMOTE
to fail to build on *nix systems as this feature is only available for
WIN32. This patch resolves the issue.

I have submitted this upstream on github and they have accepted the
patch into their 1.8 branch.

MFH this to STABLE would be nice and including in a future ERRATA
wouldn't hurt.

[delphij]

Sorry didn't act on this earlier.

It seems good in principle, but could you please commit this to vendor/libpcap/dist first, then do a merge from there if the change is already accepted upstream? This would make future maintenance easier.

Also is there a bug for reference?

[feld]

It was in this bug report that upstream confirmed they were accepting it into their 1.8 branch:

https://github.com/the-tcpdump-group/libpcap/pull/598

I do not have experience with merges in base system, but I'll get that figured out if you approve.

[feld]

If you meant a FreeBSD bug report, no -- this was something I discovered and resolved, but did not open a bug report for the FreeBSD project.

[delphij]

In D12076#251688, @feld wrote:

If you meant a FreeBSD bug report, no -- this was something I discovered and resolved, but did not open a bug report for the FreeBSD project.

Yes, it's mainly for reference purposes.