Page MenuHomeFreeBSD

Fix mlx5en(4) to properly call m_defrag.

Authored by mjoras on Aug 16 2017, 7:01 PM.
Referenced Files
Unknown Object (File)
Sat, Nov 25, 2:55 PM
Unknown Object (File)
Wed, Nov 22, 8:37 PM
Unknown Object (File)
Wed, Nov 15, 9:46 PM
Unknown Object (File)
Mon, Nov 13, 11:48 AM
Unknown Object (File)
Sun, Nov 12, 3:30 PM
Unknown Object (File)
Fri, Nov 10, 3:32 PM
Unknown Object (File)
Nov 9 2023, 9:01 PM
Unknown Object (File)
Nov 8 2023, 3:39 PM



This is essentially the same change as was previously made to mlx4en(4).
By stripping the chain of "empty" mbufs, it was removing M_PKTHDR from
the chain. This stripping is not needed since BUSDMA(9) does not map
empty mbufs.

Diff Detail

rS FreeBSD src repository - subversion
Lint Not Applicable
Tests Not Applicable

Event Timeline

334 ↗(On Diff #32134)

Can you add braces {} around this multi line statement?

334 ↗(On Diff #32134)

Sure, that's my preference as well but I wasn't so sure about the prevailing style for the driver.

This patch looks good to me. @gallatin do you want to test it aswell before it reaches -head? I'll give it a spin tomorrow.

Hans, did you ever get a chance to test this?

I'll have a look. I think we have a patch in the upstreaming list which covers this.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 3:53 PM
This revision was automatically updated to reflect the committed changes.