Add basic tests generated via automation tool [1]

[shivansh]

Summary

The set of introduced changes demonstrate a basic structure of tests
which are generated by an automation tool [1]. These tests lay the
guidelines on which future (generated) tests will be based upon.

Utilities covered -

• chflags(1)
• mkdir(1)
• rcp(1)
• rmdir(1)

The aim is to generate very basic amount of test coverage for all the
utilities in the base system. After all the utilities are covered, these
test scripts can then be manually updated.

A basic structure of testcases in a generated test -

• invalid_usage : Verifies the behavior of a utility when an invalid usage is performed for a supported option.
• ($option)_flag: Verifies the behavior of a utility when a valid usage is performed for a supported option - $option.
• no_arguments : Verifies the behavior of a utility when it is used without any supported options.

Quoting @brooks on the purpose of having a minimal test coverage -

When replacing major toolchain components, it's quite easy to subtlety
break the startup code in layout or obscure-feature dependent ways. I'm
looking absolute minimum validation of startup. If that's a real test
great, but touching every non-contrib program would be a good start.
This project idea was borne out of frustration with our extremely poor
breadth of coverage while bringing up a new ABI out of tree.

[1]: https://github.com/shivansh/smoketestsuite

Test Plan

• Execute make install from bin/($utility)/tests.
• Execute kyua test from /usr/tests/bin/($utility). All testcases should succeed.

[shivansh]

Update etc/mtree/BSD.tests.dist

[asomers]

bin/chflags/tests/chflags_test.sh

40

Hardcoding the usage string here just makes it harder to update chflags with new or changed options. It might be better merely to do atf_check -s exit:1 -e regex:"usage: chflags" chflags -f. That way we'll still get coverage of the test behavior, without duplicating human-readable stuff from chflags's source.

bin/mkdir/tests/mkdir_test.sh

43

The man page merely specifies that the command will return >0, not 64. Plus, the use of EX_USAGE and related variables has fallen out of fashion. Probably better to do atf_check -s not-exit:0 -e inline:"$usage_output" mkdir -p

[shivansh]

Address requested changes-

• Avoid hardcoding usage string
• Use "not-exit:0" for non-zero exit status

The test files weren't manually updated, relevant changes were first made in the tool and the tests generated afterwards.

[asomers]

These files look good to me. However, I'd recommend that you commit the code generation tool too. It can go into the tools directory, which is not automatically built.

[brooks]

These look good to me.