Page MenuHomeFreeBSD

x86: make the arrays that depend on MAX_APIC_ID dynamic
ClosedPublic

Authored by royger on Aug 7 2017, 10:23 AM.
Tags
None
Referenced Files
F84918805: D11912.diff
Thu, May 30, 3:20 AM
Unknown Object (File)
Dec 22 2023, 9:51 PM
Unknown Object (File)
Nov 7 2023, 10:46 AM
Unknown Object (File)
Sep 7 2023, 11:52 AM
Unknown Object (File)
Sep 7 2023, 11:46 AM
Unknown Object (File)
Sep 1 2023, 9:58 PM
Unknown Object (File)
Jun 30 2023, 5:14 PM
Unknown Object (File)
May 31 2023, 6:52 PM
Subscribers
None

Details

Summary

So that MAX_APIC_ID can be bumped without wasting memory.

Note that the usage of MAX_APIC_ID in the SRAT parsing forces the
parser to allocate memory directly from the phys_avail physical memory
array, which is not the best approach probably, but I haven't found
any other way to allocate memory so early in boot. This memory is not
returned to the system afterwards, but at least it's sized according
to the maximum APIC ID found in the MADT table.

Sponsored by: Citrix Systems R&D

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10921
Build 11309: arc lint + arc unit

Event Timeline

kib added inline comments.
sys/x86/acpica/srat.c
479

I believe this is fine, it starts to take 2 pages when max_apic_id > 512.

This revision is now accepted and ready to land.Aug 7 2017, 11:09 AM
This revision was automatically updated to reflect the committed changes.