syslog(3): example error log message should use LOG_ERR level (PR 216756)
ClosedPublic
Actions

Authored by bcr on Aug 2 2017, 3:21 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Sep 15, 6:07 PM

	Unknown Object (File)
	Mon, Sep 14, 12:44 PM

	Unknown Object (File)
	Mon, Sep 14, 7:33 AM

	Unknown Object (File)
	Sun, Sep 13, 7:18 AM

	Unknown Object (File)
	Fri, Sep 11, 2:19 PM

	Unknown Object (File)
	Thu, Sep 10, 6:20 PM

	Unknown Object (File)
	Sat, Sep 5, 8:17 PM

	Unknown Object (File)
	Sat, Sep 5, 5:10 PM

Subscribers

Details

Reviewers

None

Group Reviewers

Src Committers
manpages

Commits

rS325440: The last example used LOG_INFO, but the message itself said error.

Summary

This is the patch attached to bug 216756. The last entry in the EXAMPLE section looks like this:

syslog(LOG_INFO|LOG_LOCAL2, "foobar error: %m");

Since the message says that an error is logged, it should not be LOG_INFO, but LOG_ERROR instead. The patch addresses that.

Test Plan

Apply the patch to head/lib/libc/gen/syslog.3
Check the output: man ./head/lib/libc/gen/syslog.3

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bcr created this revision.Aug 2 2017, 3:21 PM

Herald added a reviewer: manpages. · View Herald TranscriptAug 2 2017, 3:21 PM

Herald added a subscriber: imp. · View Herald Transcript

linuxgeek_gmail.com added a subscriber: linuxgeek_gmail.com.Aug 3 2017, 2:53 PM

Closed by commit rS325440: The last example used LOG_INFO, but the message itself said error. (authored by bcr). · Explain WhyNov 5 2017, 6:24 PM

This revision was automatically updated to reflect the committed changes.

Macro ssshipit:

Revision Contents
Changeset List

Path

Size

head/

lib/

libc/

gen/

syslog.3

4 lines

Diff 34832

View Options

head/lib/libc/gen/syslog.3

syslog(3): example error log message should use LOG_ERR level (PR 216756)ClosedPublicActions