Page MenuHomeFreeBSD

www/guacamole-client: Updated to 0.9.13
ClosedPublic

Authored by ultima on Aug 2 2017, 3:59 AM.
Tags
None
Referenced Files
F84797038: D11817.diff
Tue, May 28, 6:35 PM
Unknown Object (File)
Fri, May 17, 12:04 AM
Unknown Object (File)
Mon, May 13, 11:17 AM
Unknown Object (File)
Mon, May 13, 8:28 AM
Unknown Object (File)
Mon, May 13, 8:26 AM
Unknown Object (File)
Mon, May 13, 6:08 AM
Unknown Object (File)
Sun, May 5, 9:10 AM
Unknown Object (File)
Sun, May 5, 9:10 AM
Subscribers

Details

Summary
  • Updated to 0.9.13
  • Sorted USES/OPTION section to better comply with PHB
  • Removed custom etcdir and changed to ETCDIR, added note in UPDATING

Changelog: https://guacamole.incubator.apache.org/releases/0.9.13-incubating

Reviewed by\: lifanov (mentor), matthew (mentor)
Approved by\: lifanov (mentor), matthew (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint:
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.

poudriere:
103i386
103amd64
110i386
110amd64
12i386
12amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 10800
Build 11194: arc lint + arc unit

Event Timeline

UPDATING
13

Typo: has changed

www/guacamole-client/files/pkg-message.in
1 ↗(On Diff #31465)

Typo: authentication

www/guacamole-client/Makefile
74–76

This is a good example of when to use RLN, something like:

${RLN} ${STAGEDIR}${PREFIX}/share/${PORTNAME}/guacamole.war ${STAGEDIR}${PREFIX}/apache-tomcat-8.0/webapps
  • Enabled spell checking in vim by default
  • Fixed typos
  • Modified symlinks to use RLN. Iv never seen this used and This example would probably be good to add in chapter 6.1.
  • Modified symlinks to use RLN. Iv never seen this used and This example would probably be good to add in chapter 6.1.

You are absolutely right, documentation is missing. The thing is, one day, I discovered that install knew how to make relative symbolic links if you gave it two absolute paths, and I have been using it ever since :-)

This revision is now accepted and ready to land.Aug 3 2017, 9:12 AM
In D11817#245450, @mat wrote:
  • Modified symlinks to use RLN. Iv never seen this used and This example would probably be good to add in chapter 6.1.

You are absolutely right, documentation is missing. The thing is, one day, I discovered that install knew how to make relative symbolic links if you gave it two absolute paths, and I have been using it ever since :-)

Yeah everytime I do a relative link "manually" with LN I screw it up. Everytime! Another item for my bag of magic tricks.

I'll make a diff for the example, unless you're already on it.

This revision was automatically updated to reflect the committed changes.
In D11817#245450, @mat wrote:
  • Modified symlinks to use RLN. Iv never seen this used and This example would probably be good to add in chapter 6.1.

You are absolutely right, documentation is missing. The thing is, one day, I discovered that install knew how to make relative symbolic links if you gave it two absolute paths, and I have been using it ever since :-)

Yeah everytime I do a relative link "manually" with LN I screw it up. Everytime! Another item for my bag of magic tricks.

I'll make a diff for the example, unless you're already on it.

I wrote D11839 yesterday.