Based on the zh_TW and en_US versions.
Details
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Could you please upload the Makefile or other files you modified so that we could build to test?
I intentionally made separate reviews for the issues we've talked about so we can track each one of them. I think this one will build just fine.
Do you think putting them together as one review would be better in the future?
zh_CN.UTF-8/htdocs/index.xsl | ||
---|---|---|
163 ↗ | (On Diff #31368) | Related zh_TW proposed patch: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221267 |
Thanks for the fixes!
Please fix the first 3 issues in this review. (Note that the line breaks should only happen when a space is needed in the context, for instance, after a punctuation, and before or after English).
The last one is optional.
By the way, are you uploading the diff's manually? For some reasons the context is missing and you may want to pass -U999999 when creating the diffs...
zh_CN.UTF-8/htdocs/index.xsl | ||
---|---|---|
40 ↗ | (On Diff #31640) | Minor nit: Extra space before &os;. This doesn't seem to visible rendering issue under Chrome though. |
48 ↗ | (On Diff #31640) | This (new line) would create an unwanted space. New line should only be used when there is a punctuation (comma, period, etc.) or when there is a space. |
96 ↗ | (On Diff #31640) | Whole section: links should probably use &enbase; as we don't have current translation here. |
108 ↗ | (On Diff #31640) | (No action requested) Please note that the Chinese translation for this document is very outdated. |
zh_CN.UTF-8/htdocs/index.xsl | ||
---|---|---|
96 ↗ | (On Diff #31640) | Download pages should be my first priority after this review (and it's the most important as well), and considering the fact that the whole zh_CN site is down, do you think we could just leave this at it is? We will definitely have a translation available before the zh_CN website can go back online. |
Fixed whitespace issues.
Used -U999999 with git diff to ensure that the contexts are preserved.