Page MenuHomeFreeBSD
Differential D11792

Simplified Chinese Translation Project: Update index.xsl
ClosedPublic
Actions

Authored by ygy on Jul 31 2017, 6:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 8 2024, 2:36 PM
Unknown Object (File)
Dec 20 2023, 7:29 AM
Unknown Object (File)
Nov 7 2023, 10:23 PM
Unknown Object (File)
Nov 7 2023, 9:11 PM
Unknown Object (File)
Nov 7 2023, 5:46 PM
Unknown Object (File)
Nov 7 2023, 1:51 AM
Unknown Object (File)
Nov 6 2023, 2:14 PM
Unknown Object (File)
Oct 6 2023, 9:00 PM
View All 28 Files
Subscribers
wblock

Details

Reviewers
delphij
rcyu
kevlo
loader
Commits
rD50658: sync with the English version (Based on the zh_TW and en_US versions)
Summary

Based on the zh_TW and en_US versions.

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ygy created this revision.Jul 31 2017, 6:33 AM
delphij added a reviewer: loader.Jul 31 2017, 6:55 AM
ygy updated this revision to Diff 31368.Jul 31 2017, 6:58 AM
rcyu edited edge metadata.Jul 31 2017, 7:04 AM

Could you please upload the Makefile or other files you modified so that we could build to test?

ygy added a comment.Jul 31 2017, 7:13 AM
In D11792#244472, @rcyu wrote:

Could you please upload the Makefile or other files you modified so that we could build to test?

I intentionally made separate reviews for the issues we've talked about so we can track each one of them. I think this one will build just fine.

Do you think putting them together as one review would be better in the future?

rcyu accepted this revision.Jul 31 2017, 2:21 PM
This revision is now accepted and ready to land.Jul 31 2017, 2:21 PM
rcyu added a comment.Jul 31 2017, 2:27 PM
In D11792#244478, @cyang_freebsdfoundation.org wrote:
In D11792#244472, @rcyu wrote:

Could you please upload the Makefile or other files you modified so that we could build to test?

I intentionally made separate reviews for the issues we've talked about so we can track each one of them. I think this one will build just fine.

Do you think putting them together as one review would be better in the future?

That's okay. I can patch both diff together to see the outcome of the website look.

delphij requested changes to this revision.Aug 4 2017, 11:59 PM
delphij added inline comments.
zh_CN.UTF-8/htdocs/index.xsl
141 ↗(On Diff #31368)

Please fix the title properties, they should be translated (as some screen readers may require these).

163 ↗(On Diff #31368)

I think enbase should be used here (also apply to zh_TW version) because no translation is available.

This revision now requires changes to proceed.Aug 4 2017, 11:59 PM
ygy updated this revision to Diff 31640.Aug 6 2017, 6:05 AM
ygy edited edge metadata.

Update the diff based on review comments.

ygy updated this revision to Diff 31641.Aug 6 2017, 6:21 AM

More properties fixed.

ygy marked 2 inline comments as done.Aug 6 2017, 6:22 AM
ygy added inline comments.Aug 6 2017, 6:27 AM
zh_CN.UTF-8/htdocs/index.xsl
163 ↗(On Diff #31368)

Related zh_TW proposed patch: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221267

delphij requested changes to this revision.Aug 6 2017, 6:47 AM

Thanks for the fixes!

Please fix the first 3 issues in this review. (Note that the line breaks should only happen when a space is needed in the context, for instance, after a punctuation, and before or after English).

The last one is optional.

By the way, are you uploading the diff's manually? For some reasons the context is missing and you may want to pass -U999999 when creating the diffs...

zh_CN.UTF-8/htdocs/index.xsl
40 ↗(On Diff #31640)

Minor nit: Extra space before &os;. This doesn't seem to visible rendering issue under Chrome though.

48 ↗(On Diff #31640)

This (new line) would create an unwanted space. New line should only be used when there is a punctuation (comma, period, etc.) or when there is a space.

96 ↗(On Diff #31640)

Whole section: links should probably use &enbase; as we don't have current translation here.

108 ↗(On Diff #31640)

(No action requested) Please note that the Chinese translation for this document is very outdated.

This revision now requires changes to proceed.Aug 6 2017, 6:47 AM
ygy added inline comments.Aug 6 2017, 8:49 AM
zh_CN.UTF-8/htdocs/index.xsl
96 ↗(On Diff #31640)

Download pages should be my first priority after this review (and it's the most important as well), and considering the fact that the whole zh_CN site is down, do you think we could just leave this at it is? We will definitely have a translation available before the zh_CN website can go back online.

ygy updated this revision to Diff 31659.Aug 6 2017, 8:55 AM
ygy edited edge metadata.

Fixed whitespace issues.
Used -U999999 with git diff to ensure that the contexts are preserved.

ygy marked 3 inline comments as done.Aug 6 2017, 8:55 AM
delphij accepted this revision.Aug 6 2017, 9:03 AM
This revision is now accepted and ready to land.Aug 6 2017, 9:03 AM
Closed by commit rD50658: sync with the English version (Based on the zh_TW and en_US versions) (authored by rcyu). · Explain WhyAug 10 2017, 4:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
zh_CN.UTF-8/
htdocs/
164 lines

Diff 31878

View Options

head/zh_CN.UTF-8/htdocs/index.xsl

Loading...