Page MenuHomeFreeBSD
Differential D11787

Don't trace threads that have interrupts disabled.
ClosedPublic
Actions

Authored by markj on Jul 31 2017, 1:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 1:25 PM
Unknown Object (File)
Mon, Nov 25, 9:28 AM
Unknown Object (File)
Sun, Nov 24, 11:48 AM
Unknown Object (File)
Nov 18 2024, 3:04 AM
Unknown Object (File)
Nov 18 2024, 12:18 AM
Unknown Object (File)
Nov 17 2024, 6:32 PM
Unknown Object (File)
Nov 17 2024, 5:44 PM
Unknown Object (File)
Nov 17 2024, 2:06 PM
View All 48 Files
Subscribers
None

Details

Reviewers
jhb
kib
Commits
rS321803: Don't trace running threads that have interrupts disabled.
Summary

The register file of such a thread is in an indeterminate state, so we
shouldn't assume that the frame pointer is valid. In particular, we may
be in the middle of restoring host registers after a vmexit.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 10756
Build 11151: arc lint + arc unit

Event Timeline

markj created this revision.Jul 31 2017, 1:12 AM
Harbormaster completed remote builds in B10756: Diff 31361.Jul 31 2017, 1:12 AM
markj edited the summary of this revision. (Show Details)Jul 31 2017, 1:13 AM
markj added reviewers: jhb, kib.
kib accepted this revision.Jul 31 2017, 7:20 AM

This is fine, but then you do not need NMI.

This revision is now accepted and ready to land.Jul 31 2017, 7:20 AM
markj added a comment.Jul 31 2017, 5:01 PM
In D11787#244481, @kib wrote:

This is fine, but then you do not need NMI.

We use an NMI to avoid to avoid a deadlock: the case where the target thread holds a spinlock and thus has interrupts disabled, and is blocked on the thread lock held by the stack_save_td_running() caller.

Closed by commit rS321803: Don't trace running threads that have interrupts disabled. (authored by markj). · Explain WhyJul 31 2017, 5:58 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
x86/
x86/
7 lines

Diff 31361

View Options

sys/x86/x86/stack_machdep.c

Loading...