Page MenuHomeFreeBSD

bhyve/pci_e82545.c: squelch gcc warning for noreturn procedure
ClosedPublic

Authored by rlibby on Jul 28 2017, 5:53 PM.

Details

Summary

Gcc complained that e82545_tx_thread has a return type declared but
doesn't return anything. Annotate the procedure with _Noreturn.

An alternate approach might have been to add shutdown logic for this
pthread. I looked around some and didn't notice any shutdown hooks.

Test Plan

gcc

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rlibby created this revision.Jul 28 2017, 5:53 PM
grehan accepted this revision.Jul 28 2017, 5:55 PM

Shutdown hooks will make it some day...

This revision is now accepted and ready to land.Jul 28 2017, 5:55 PM
This revision was automatically updated to reflect the committed changes.