Page MenuHomeFreeBSD
Differential D11774

bhyve/pci_e82545.c: squelch gcc warning for noreturn procedure
ClosedPublic
Actions

Authored by rlibby on Jul 28 2017, 5:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 20, 5:53 PM
Unknown Object (File)
Mon, Apr 20, 9:54 AM
Unknown Object (File)
Thu, Apr 16, 9:51 PM
Unknown Object (File)
Tue, Apr 14, 7:03 PM
Unknown Object (File)
Sat, Apr 11, 4:42 PM
Unknown Object (File)
Fri, Apr 10, 8:25 AM
Unknown Object (File)
Thu, Apr 9, 1:42 PM
Unknown Object (File)
Thu, Apr 9, 12:42 PM
View All Files
Subscribers
grehan
markj
tychon

Details

Reviewers
mav
grehan
Commits
rS321668: bhyve/pci_e82545.c: squelch gcc warning for noreturn procedure
Summary

Gcc complained that e82545_tx_thread has a return type declared but
doesn't return anything. Annotate the procedure with _Noreturn.

An alternate approach might have been to add shutdown logic for this
pthread. I looked around some and didn't notice any shutdown hooks.

Test Plan

gcc

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rlibby created this revision.Jul 28 2017, 5:53 PM
Harbormaster completed remote builds in B10731: Diff 31314.Jul 28 2017, 5:53 PM
grehan accepted this revision.Jul 28 2017, 5:55 PM

Shutdown hooks will make it some day...

This revision is now accepted and ready to land.Jul 28 2017, 5:55 PM
markj added a comment.Jul 28 2017, 5:57 PM

Approved.

Closed by commit rS321668: bhyve/pci_e82545.c: squelch gcc warning for noreturn procedure (authored by rlibby). · Explain WhyJul 28 2017, 9:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
bhyve/
2 lines

Diff 31325

View Options

head/usr.sbin/bhyve/pci_e82545.c

Loading...