Page MenuHomeFreeBSD
Differential D11661

Add pctrie_init() and vm_radix_init() to initialize generic pctrie and vm_radix trie.
ClosedPublic
Actions

Authored by kib on Jul 19 2017, 6:43 PM.
Tags
None
Referenced Files
F103209371: D11661.id30978.diff
Fri, Nov 22, 6:33 AM
F103202495: D11661.id30977.diff
Fri, Nov 22, 5:02 AM
Unknown Object (File)
Thu, Nov 21, 2:39 AM
Unknown Object (File)
Wed, Nov 20, 1:02 PM
Unknown Object (File)
Mon, Nov 18, 2:58 PM
Unknown Object (File)
Mon, Nov 18, 3:53 AM
Unknown Object (File)
Mon, Nov 18, 2:39 AM
Unknown Object (File)
Mon, Nov 18, 2:04 AM
View All 69 Files
Subscribers
imp

Details

Reviewers
alc
markj
Commits
rS321247: Add pctrie_init() and vm_radix_init() to initialize generic pctrie and
Summary

Existing vm_radix_init() renamed to vm_radix_zinit().

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib created this revision.Jul 19 2017, 6:43 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 19 2017, 6:43 PM
markj accepted this revision.Jul 19 2017, 7:22 PM
This revision is now accepted and ready to land.Jul 19 2017, 7:22 PM
alc added inline comments.Jul 19 2017, 8:21 PM
sys/sys/_pctrie.h
51 ↗(On Diff #30970)

To maintain sorted order, this should come first.

sys/vm/vm_radix.h
49 ↗(On Diff #30970)

There is also a vm_radix_is_empty() in _vm_radix.h. Move this there?

kib updated this revision to Diff 30977.Jul 19 2017, 8:28 PM
kib marked 2 inline comments as done.
kib edited edge metadata.

Move inlines around.

This revision now requires review to proceed.Jul 19 2017, 8:28 PM
alc edited edge metadata.Jul 19 2017, 8:37 PM

Should the pctrie inlines analogously move from sys/_pctrie.h to sys/pctrie.h?

kib updated this revision to Diff 30978.Jul 19 2017, 8:42 PM

Move inlines from _pctrie.h to pctrie.h.

alc accepted this revision.Jul 19 2017, 8:48 PM
This revision is now accepted and ready to land.Jul 19 2017, 8:48 PM
Closed by commit rS321247: Add pctrie_init() and vm_radix_init() to initialize generic pctrie and (authored by kib). · Explain WhyJul 19 2017, 8:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
sys/
10 lines
14 lines
vm/
10 lines
4 lines
16 lines
2 lines

Diff 30980

View Options

head/sys/sys/_pctrie.h

Loading...
View Options

head/sys/sys/pctrie.h

Loading...
View Options

head/sys/vm/_vm_radix.h

Loading...
View Options

head/sys/vm/vm_object.c

Loading...
View Options

head/sys/vm/vm_radix.h

Loading...
View Options

head/sys/vm/vm_radix.c

Loading...