devel/pecl-weakref: Add PORTSCOUT
ClosedPublic
Actions

Authored by joneum on Jul 17 2017, 5:17 PM.

Details

Reviewers

tz
rene
miwi

Commits

rP446389: - Bump PORTREVISION: Limit portscout to version 0.2,

Summary

Bump PORTREVISION: Limit portscout to version 0.2, newer versions are available in www/pecl-weakref2.

Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

joneum created this revision.Jul 17 2017, 5:17 PM

Herald added a subscriber: mat. · View Herald TranscriptJul 17 2017, 5:17 PM

Harbormaster completed remote builds in B10530: Diff 30876.Jul 17 2017, 5:17 PM

Why bump PORTREVISION ?

To rephrase mat a little:
A PORTREVISION bump is not needed if you only set PORTSCOUT. The changed PORTREVISION will trigger a rebuild of the package, but without any functional change this is just a waste of time and resources of the user and the buildfarm.
If there aren't any other reasons please remove the PORTSCOUT.

This revision now requires changes to proceed.Jul 18 2017, 12:11 PM

There is no reason to delete. For higher versions, there are ww/pecl-weakref2

joneum removed a subscriber: mat.Jul 19 2017, 7:00 AM

Keep in mind, commit messages are about why you are doing things. Never describe what you are doing, people can see what you are doing by looking at the diff.

Your summary says: "Add PORTSCOUT", which is awful, it should look something like:

Limit portscout to version 0.2, newer versions are available in www/pecl-weakref2.

There is no need to bump PORTREVISION, Please re-read section 5.2.2.1. PORTREVISION of the Porter's Handbook very carefully. Do not hesitate to ask if you do not understand it.