Differential D11558 Authored by tcberner on Jul 11 2017, 5:29 PM.
Details
Summary Everything should be fine now.
Test Plan Exp-run
Diff Detail
Event TimelineHerald added a reviewer: portmgr. · View Herald TranscriptJul 11 2017, 5:30 PM2017-07-11 17:30:11 (UTC+0) tcberner edited the summary of this revision. (Show Details)Jul 11 2017, 5:33 PM2017-07-11 17:33:08 (UTC+0)
Harbormaster completed remote builds in B10437: Diff 30668.Jul 12 2017, 6:47 AM2017-07-12 06:47:23 (UTC+0) tcberner edited the summary of this revision. (Show Details)Jul 12 2017, 8:21 AM2017-07-12 08:21:52 (UTC+0) Comment Actions The user guide build seems to fail. Chapter 19.
[473] [474] (./users_guide.ind [475] [476] [477] [478] [479] [480] [481]
[482] [483] [484] [485] [486] [487]
Underfull \hbox (badness 10000) in paragraph at lines 1240--1241
[]\EU1/DejaVuSerif(0)/m/n/10 __GLASGOW_HASKELL_PATCHLEVEL1__,
Underfull \hbox (badness 10000) in paragraph at lines 1241--1242
[]\EU1/DejaVuSerif(0)/m/n/10 __GLASGOW_HASKELL_PATCHLEVEL2__,
[488] [489]
Underfull \hbox (badness 10000) in paragraph at lines 1498--1499
[]| \EU1/DejaVuSerif(0)/m/n/10 -Wmissing-pattern-synonym-signatures,
[490] [491] [492] [493] [494] [495] [496] [497] [498] [499]) (./users_guide.aux
)
LaTeX Warning: There were multiply-defined labels.
)
(see the transcript file for additional information)
Output written on users_guide.pdf (515 pages).
Transcript written on users_guide.log.
cp docs/users_guide/build-pdf/users_guide/users_guide.pdf docs/users_guide/users_guide.pdf
gmake[2]: *** [Makefile:134: all] Error 2
gmake[2]: Leaving directory '/usr/home/ports/lang/ghc/work/ghc-8.0.2'
===> Compilation failed unexpectedly.
Try to set MAKE_JOBS_UNSAFE=yes and rebuild before reporting the failure to
the maintainer.
*** Error code 1
Stop.
make[1]: stopped in /usr/home/ports/lang/ghc
*** Error code 1
Stop.
make: stopped in /usr/home/ports/lang/ghc
===>>> make build failed for lang/ghc
===>>> Aborting update
===>>> You can restart from the point of failure with this command line:
portmaster <flags> lang/ghc
This command has been saved to /tmp/portmasterfail.txtComment Actions I believe this is the same error I also get when building it outside of poudriere. Let me double check. Comment Actions If you scroll all the way up you should see File "/usr/local/lib/python2.7/site-packages/docutils/writers/_html_base.py", line 671, in depart_document
assert not self.context, 'len(context) = %s' % len(self.context)
AssertionError: len(context) = 1
The full traceback has been saved in /wrkdirs/usr/local/poudriere/ports/ghc/lang/ghc/work/ghc-8.0.2/tmp/sphinx-err-oiNtsC.log, if you want to report the issue to the developers.
Please also report this if it was a user error, so that a better error message can be provided next time.
A bug report can be filed in the tracker at <https://github.com/sphinx-doc/sphinx/issues>. Thanks!
[213]Comment Actions devel/hs-transformers-base is failing with following: ===> Building for hs-transformers-base-0.4.4
Building transformers-base-0.4.4...
Preprocessing library transformers-base-0.4.4...
[1 of 1] Compiling Control.Monad.Base ( src/Control/Monad/Base.hs, dist/build/Control/Monad/Base.o )
src/Control/Monad/Base.hs:22:1: warning: [-Wunused-imports]
The import of ‘Data.Monoid’ is redundant
except perhaps to import instances from ‘Data.Monoid’
To import instances alone, use: import Data.Monoid()
[1 of 1] Compiling Control.Monad.Base ( src/Control/Monad/Base.hs, dist/build/Control/Monad/Base.p_o )
src/Control/Monad/Base.hs:48:1: error:
Failed to load interface for ‘Control.Monad.STM’
Perhaps you haven't installed the profiling libraries for package ‘stm-2.4.4.1’?
Use -v to see a list of the files searched for.
*** Error code 1Complete build log at https://pastebin.com/raw/4V2dkUXv Comment Actions Is there any reason not to always build with profiling and dynamic ? If not I would also like to get rid of these options. Because, it just makes stuff unnecessary breaky and buggy, as the last comment shows. Comment Actions
Sorry, this is indeed my fault, I missed resetting hs-stm port's options, while the result. Also, the reason we'd these OPTIONs is so as to not force it on someone, as we're essentially adding another run of compilation cycle per option, so if someone doesn't need/care for these options, can just disable them, and get smaller build times. The breaky, and buggy part was entirely my fault, which I failed to notice. Comment Actions I think there is nothing wrong with the DYNAMIC and PROFILE options. The issue that Ashish was experiencing is due to the fact that GHC cannot build either a dynamically-linked or profiling version of a library/executable if any of the dependencies does not have those versions built and installed. The reason why PROFILE is not enabled by default is also that it is mostly a developer option. The _p version of the libraries contain some extra bits for doing performance profiling and I do not think it would make sense to build and package them unless the user wants to have them specifically. (They can increase the size of the package by about one third, I guess.) On that other hand, as far as I remember, DYNAMIC has been a default option for a while now. Comment Actions I have added some comments to the patch inline. In addition to them, a general remark: I believe all ports where there was no version change, the PORTREVISION must be bumped because a major dependency has still changed, the compiler. That is, they will have to rebuilt anyway. I do not know if this is still required these days, though.
Comment Actions Thanks, I'll update the review later.
Comment Actions Do you really want to upgrade hoauth2 to its latest version? gitit uses versions 0.4.x (x >= 2) or 0.5.x, and the Network.Gitit.Authentication.Github module would need to be heavily patched in order to be able to build with version 1.3.0 (due changes in the API). Comment Actions I think the following ports could be safely dropped as they got deprecated and unmaintained in upstream:
Comment Actions Unfortunately, the documentation for lang/ghc cannot yet be built with the current version of textproc/py-sphinx in the tree. This has been reported and fixed upstream but it is not there in the ports. I submitted a bug report for that. Comment Actions All right, I have worked myself through all the mentioned issues as part of my more exhaustive review that eventually resulted in an updated version of the published diff. Basically now all the ports build fine, except devel/stack where I could not yet figure out what causes the build to fail. Comment Actions I found some additional build problems on i386 that I have now fixed. I updated the previously referenced diff with those changes. Comment Actions When I was discussing with tobik how to deal with devel/stack, he spotted that lang/ghc does not configure with setting the DOCS option to off. I investigated the issue, and it turned out the X_SUB_LIST_OFF variables do not properly escape the '#' characters so sed(1) fails. They have to be prefixed with a backslash in order to work. I updated my diff to incorporate this fix. Comment Actions I think it did not, but since I have spotted other problems, I kept working on the diff, which has been updated by now. To the latest version, it features the following changes:
tcberner edited the summary of this revision. (Show Details)Aug 7 2017, 5:54 PM2017-08-07 17:54:02 (UTC+0) Harbormaster completed remote builds in B10929: Diff 31715.Aug 7 2017, 6:02 PM2017-08-07 18:02:55 (UTC+0) Comment Actions @tcberner : You seem to forgot to remove the SUBDIR entry for hs-directory in devel/Makefile, so I fixed it. In addition to that, the new version of my diff now contains:
Comment Actions While toying with the related commit message, I realized that your change wants to re-add the math/hs-nats port that was removed on the last major update. It actually had a reason: the functionality of the nats package has been merged in the base package that ships with GHC, and it looks like that is still the case. I have checked it, and it turned out that only the converters/hs-aeson-compat port would need it. So I changed the port to not to use the nats package, hence there is no need to resurrect the math/hs-nats port. I updated my diff with this modification. Closed by commit rP447548: - Update The Glorious Glasgow Haskell Compiler to version 8.0.2 (authored by tcberner). · Explain WhyAug 9 2017, 1:49 AM2017-08-09 01:49:12 (UTC+0) This revision was automatically updated to reflect the committed changes. Large DiffThis large diff affects 1,407 files. Files without inline comments have been collapsed. Expand All Files
Revision Contents
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||